Created attachment 160847 [details] Patch to fix spell checker path and examples The current squirrelmail port uses a regex to replace 'ispell' with '/usr/local/bin/ispell' except ispell has not been in ports since early 2014. 'aspell' is an appropriate and working replacement. The attached patch makes the port install a sqspell_config.php that is prepared for aspell and removes unneeded examples for ispell to avoid letting the fixed regex make the result even more confusing. I have tried installing and using textproc/aspell-ispell however it complains "exec: aspell: not found" which is exactly the problem the port Makefile regex was trying to solve in the first place. Since aspell-ispell depends on aspell, it makes sense to use aspell directly. I am also attaching a build log from poudriere with a bunch of my compile settings from make.conf redacted.
Created attachment 160848 [details] poudriere build log
I agree that switching the default from ispell to aspell makes sense, especially given that ispell doesn't even exist in the ports tree anymore. Aside from doing that switch it doesn't actually *do* anything. It doesn't bring in an aspell dependency, and it doesn't change the config scripts so that people know what they're enabling, etc. By all means, please correct me if I'm wrong here! My recommendation is that you submit patch this upstream and that we see how SM integrates it. Is that fair?
I will try to look at upstream if you can tell me the location of the upstream copy/branch that is most likely to be snapshotted by the port next. For example I have looked at http://sourceforge.net/p/squirrelmail/code/HEAD/tree/branches/SM-1_5_1/squirrelmail/plugins/squirrelspell/sqspell_config.php and http://sourceforge.net/p/squirrelmail/code/HEAD/tree/trunk/squirrelmail/plugins/squirrelspell/sqspell_config.php but both have near 100 lines while the one extracted by the port has 36. I can't immediately explain where these modifications are coming from. The change does make a difference for those that have aspell installed and don't want a locally modified sqspell_config.php to be reverted every time the squirrelmail package gets reinstalled. I got burned by this several times so I am trying to have the port do a more sensible thing. I had noticed the squirrelmail port does not directly depend on any spell checker thus that functionality won't work out of the box, and I thought about changing that, but aspell doesn't include any dictionaries by default. The local admin must choose what language dictionary ports they want to install which will pull in aspell, if they even care about the spell checking plugin. Or we could default to English. Thanks.
A commit references this bug: Author: adamw Date: Sat Oct 3 18:04:54 UTC 2015 New revision: 398550 URL: https://svnweb.freebsd.org/changeset/ports/398550 Log: ispell isn't available in FreeBSD and hasn't been for quite some time. Change references to ispell into aspell, which is readily available. PR: 202980 Submitted by: mcdouga9@egr.msu.edu Changes: head/mail/squirrelmail/Makefile head/mail/squirrelmail/files/patch-plugins__squirrelspell__sqspell_config.php
Sorry about sitting on this PR for so long. It's a good change and I've committed it. I didn't add a dependency on aspell... not everyone will want it and it's easy to do yourself. And as you said, the need for separate dictionaries makes trying to do it ourselves more complex. Thanks for submitting this, and for your patience.