Bug 203237 - [patch] x11/virtualgl: reduce number of dependencies, add SSL option
Summary: [patch] x11/virtualgl: reduce number of dependencies, add SSL option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-09-21 17:05 UTC by Andriy Voskoboinyk
Modified: 2016-03-14 21:23 UTC (History)
2 users (show)

See Also:
rakuco: maintainer-feedback-

Attachments
Makefile.diff (1.43 KB, patch)
2015-09-21 17:05 UTC, Andriy Voskoboinyk 		no flags Details | Diff
portlint.log (1.17 KB, text/plain)
2015-09-21 17:05 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-default.log (259.72 KB, text/plain)
2015-09-21 17:06 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-openssl.log (261.96 KB, text/plain)
2015-09-21 17:06 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-10.2-amd64-default.log (309.17 KB, text/plain)
2015-09-21 19:09 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-10.2-amd64-openssl.log (312.84 KB, text/plain)
2015-09-21 20:01 UTC, Andriy Voskoboinyk 		no flags Details
Makefile.diff (1.63 KB, patch)
2016-03-14 18:39 UTC, Andriy Voskoboinyk 		rakuco: maintainer-approval+
Details | Diff
portlint.log (229 bytes, text/plain)
2016-03-14 18:41 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-default.log (181.90 KB, text/plain)
2016-03-14 18:42 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-openssl.log (183.10 KB, text/plain)
2016-03-14 18:43 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-xv.log (188.55 KB, text/plain)
2016-03-14 18:45 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-all.log (189.77 KB, text/plain)
2016-03-14 18:46 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-10.2-amd64-default.log (198.57 KB, text/plain)
2016-03-14 19:19 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-10.2-amd64-all.log (205.97 KB, text/plain)
2016-03-14 20:12 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-10.2-amd64-openssl.log (199.01 KB, text/plain)
2016-03-14 21:04 UTC, Andriy Voskoboinyk 		no flags Details
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-09-21 17:05:12 UTC 
Created attachment 161235 [details]
Makefile.diff

- Drop dependencies, that are not from ${WRKSRC}/BUILDING.txt.
- Add optional OpenSSL support.
- Wrap long line at 80 characters.
- Bump PORTREVISION.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-09-21 17:05:43 UTC 
Created attachment 161236 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-09-21 17:06:16 UTC 
Created attachment 161237 [details]
poudriere-9.3-i386-default.log
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-09-21 17:06:36 UTC 
Created attachment 161238 [details]
poudriere-9.3-i386-openssl.log
Comment 4 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-09-21 19:09:04 UTC 
Created attachment 161250 [details]
poudriere-10.2-amd64-default.log
Comment 5 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-09-21 20:01:45 UTC 
Created attachment 161253 [details]
poudriere-10.2-amd64-openssl.log
Comment 6 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-02-29 10:50:28 UTC 
Hi Andriy,

Can you confirm if your patch is still valid with the current version of the port (2.4.1)? If so, can you rebase your patch on top of it and resubmit so I can land it?
Comment 7 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 18:39:55 UTC 
Created attachment 168172 [details]
Makefile.diff

- Rebase.
- Turn (added) XVideo dependency into an option.
- Drop obsolete comment (jpeg-turbo can be compiled for non-amd64/i386 architectures since r388256; however, I have not tested this port with them).
Comment 8 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 18:41:04 UTC 
Created attachment 168173 [details]
portlint.log
Comment 9 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 18:42:37 UTC 
Created attachment 168174 [details]
poudriere-9.3-i386-default.log
Comment 10 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 18:43:36 UTC 
Created attachment 168175 [details]
poudriere-9.3-i386-openssl.log
Comment 11 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 18:45:24 UTC 
Created attachment 168176 [details]
poudriere-9.3-i386-xv.log
Comment 12 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 18:46:59 UTC 
Created attachment 168178 [details]
poudriere-9.3-i386-all.log
Comment 13 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 19:19:55 UTC 
Created attachment 168183 [details]
poudriere-10.2-amd64-default.log
Comment 14 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 20:12:23 UTC 
Created attachment 168184 [details]
poudriere-10.2-amd64-all.log
Comment 15 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-03-14 21:04:21 UTC 
Created attachment 168186 [details]
poudriere-10.2-amd64-openssl.log
Comment 16 commit-hook freebsd_committer freebsd_triage 2016-03-14 21:22:42 UTC 
A commit references this bug:

Author: rakuco
Date: Mon Mar 14 21:21:43 UTC 2016
New revision: 411115
URL: https://svnweb.freebsd.org/changeset/ports/411115

Log:
  Reduce number of dependencies, add SSL option.

  - Drop dependencies, that are not from ${WRKSRC}/BUILDING.txt.
  - Add optional OpenSSL support.
  - Turn (added) XVideo dependency into an option.
  - Drop obsolete comment (jpeg-turbo can be compiled for non-amd64/i386
    architectures since r388256).
  - Bump PORTREVISION.

  PR:		203237
  Submitted by:	Andriy Voskoboinyk <s3erios@gmail.com>
  Approved by:	maintainer timeout (175 days)

Changes:
  head/x11/virtualgl/Makefile
Comment 17 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-14 21:23:07 UTC 
Committed, thanks!