Bug 203291 - [MAINTAINER UPDATE] Update math/ipopt to version 3.12.4
Summary: [MAINTAINER UPDATE] Update math/ipopt to version 3.12.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-09-23 18:59 UTC by Pedro F. Giffuni
Modified: 2015-10-12 17:03 UTC (History)
2 users (show)

See Also:

Attachments
ipopt update (1.92 KB, patch)
2015-09-23 18:59 UTC, Pedro F. Giffuni 		no flags Details | Diff
ipopt update (2.13 KB, patch)
2015-10-06 15:12 UTC, Pedro F. Giffuni 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer freebsd_triage 2015-09-23 18:59:42 UTC 
Created attachment 161310 [details]
ipopt update

New version: bug fixes mostly
Comment 1 Bartek Rutkowski freebsd_committer freebsd_triage 2015-10-06 08:54:39 UTC 
Hi, the poudriere testing is reporting issues with plist:

Error: Missing: %%DOCSDIR%%/Ipopt/AUTHORS
Error: Missing: %%DOCSDIR%%/Ipopt/LICENSE
Error: Missing: %%DOCSDIR%%/Ipopt/README
Error: Missing: %%DOCSDIR%%/Ipopt/ipopt_addlibs_c.txt
Error: Missing: %%DOCSDIR%%/Ipopt/ipopt_addlibs_cpp.txt
Error: Missing: %%DOCSDIR%%/Ipopt/ipopt_addlibs_f.txt
Comment 2 Pedro F. Giffuni freebsd_committer freebsd_triage 2015-10-06 15:12:01 UTC 
Created attachment 161765 [details]
ipopt update

Sorry: "make check-plist" has reproduced the issue.
It was a good chance to add real documentation though.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-10-12 12:26:51 UTC 
A commit references this bug:

Author: riggs
Date: Mon Oct 12 12:26:07 UTC 2015
New revision: 399119
URL: https://svnweb.freebsd.org/changeset/ports/399119

Log:
  Update to upstream version 3.12.4

  While on it:
  Convert to OPTION helpers

  PR:		203291
  Submitted by:	pfg@FreeBSD.org

Changes:
  head/math/ipopt/Makefile
  head/math/ipopt/distinfo
  head/math/ipopt/pkg-plist
Comment 4 Thomas Zander freebsd_committer freebsd_triage 2015-10-12 12:31:52 UTC 
While on it, I did a trivial change to use OPTION helpers instead of .if{} clauses. Hope that's fine.
Comment 5 Pedro F. Giffuni freebsd_committer freebsd_triage 2015-10-12 14:15:09 UTC 
(In reply to Thomas Zander from comment #4)

No pŕoblem, thanks!

Are those documented? I missed them in the porting handbook.
Comment 6 Thomas Zander freebsd_committer freebsd_triage 2015-10-12 17:03:38 UTC 
(In reply to Pedro F. Giffuni from comment #5)

In the recent past (July to recent) there was quite some work on introducing OPTION helpers for nearly everything. The porters handbook may lag a bit at the moment, we may need to address that.

Regarding the specific changes to your patch:
The Makefile targets handling on OPTIONs (post-patch-OPTION-on) is documented in ${PORTSDIR}/CHANGES (see entry from 20150701), the CXXFLAGS helper is documented in ${PORTSDIR}/bsd.options.mk