Bug 203297 - [patch] graphics/rawstudio: core dump on start-up
Summary: [patch] graphics/rawstudio: core dump on start-up
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-23 21:03 UTC by J.R. Oldroyd
Modified: 2015-10-16 20:41 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (samm)

Attachments
patch to fix GType conversion (345 bytes, patch)
2015-09-23 21:15 UTC, J.R. Oldroyd 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description J.R. Oldroyd 2015-09-23 21:03:39 UTC 
On running rawstudio, this happens:

        $ rawstudio

        ** (rawstudio:18309): WARNING **: Lensfun library version is unknown.
        zsh: segmentation fault  /usr/local/bin/rawstudio

The problem is in rs-batch.c, make_batch_options(), this code:

        active = gui_confbox_get_active(filetype_confbox);
        if (!active)
                active = GUINT_TO_POINTER(g_type_from_name("RSJpegfile"));
        filetype_changed(active, queue);

The core dump comes in filetype_changed().  It appears that gui_confbox_get_active() is returning an invalid value.

A work-around is to not call filetype_changed() at this point.
Comment 1 J.R. Oldroyd 2015-09-23 21:15:20 UTC 
Created attachment 161316 [details]
patch to fix GType conversion

This patch, which is consistent with changes already made in the github source, fixes the problem.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-10-16 20:23:04 UTC 
A commit references this bug:

Author: pawel
Date: Fri Oct 16 20:22:10 UTC 2015
New revision: 399513
URL: https://svnweb.freebsd.org/changeset/ports/399513

Log:
  Add patch fixing segfault at startup

  PR:		203297
  Submitted by:	fbsd@opal.com
  Approved by:	maintainer timeout
  MFH:		2015Q4

Changes:
  head/graphics/rawstudio/Makefile
  head/graphics/rawstudio/files/patch-src_rs-batch.c
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-10-16 20:41:06 UTC 
A commit references this bug:

Author: pawel
Date: Fri Oct 16 20:40:37 UTC 2015
New revision: 399515
URL: https://svnweb.freebsd.org/changeset/ports/399515

Log:
  MFH: r399513

  Add patch fixing segfault at startup

  PR:		203297
  Submitted by:	fbsd@opal.com
  Approved by:	maintainer timeout
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q4/
  branches/2015Q4/graphics/rawstudio/Makefile
  branches/2015Q4/graphics/rawstudio/files/patch-src_rs-batch.c