Created attachment 161408 [details] Update and fix xfractint - Update to version 20.04p14 (Aug 2015) - Pet portlint - Drop workarounds for older math functions re-enabling use of sinhl(3), coshl(3) and frexp(3). - This unbreaks this classic port.
A commit references this bug: Author: danfe Date: Fri Oct 16 07:47:48 UTC 2015 New revision: 399429 URL: https://svnweb.freebsd.org/changeset/ports/399429 Log: - Update to version 20.04p14 and unbreak this classic port - Drop workarounds for older math functions and reenable use of sinhl(3), coshl(3), and frexp(3) on FreeBSD versions that have them in libm - Remove useless definite article from COMMENT line - Install manual page with its section suffix (1) instead of "man" - Unmute installation commands, sort pkg-plist, trim pkg-descr while here PR: 203360 Submitted by: pfg Approved by: maintainer timeout (since 2015-09-26) Changes: head/graphics/xfractint/Makefile head/graphics/xfractint/distinfo head/graphics/xfractint/files/patch-common__mpmath_c.c head/graphics/xfractint/files/patch-common__soi.c head/graphics/xfractint/files/patch-unix__fpu087.c head/graphics/xfractint/files/pre-1000034-libm-patch head/graphics/xfractint/pkg-descr head/graphics/xfractint/pkg-plist
Thanks for the patch, quite good overall. I've thrown in some extra improvements and style fixes, most notably: - portlint(1) suggesting to use ${FALSE} instead of "false" in DESKTOP_ENTRIES is bogus: fd.org spec requires this field to be literal "true" or "false" -- it's a property, not a command, while our ${FALSE} is really false(1). This is a long-standing bug (false positive) of portlint(1); - Dropping workarounds for older math functions has to be conditional because new functions were not merged to stable/9; - I've decided to leave existing patches untouched, because commit diff already contained enough changes, and I did not want to add more non-functional noise to it. Hope you don't mind!
Assign to committer that resolved