Bug 203482 - [PATCH] math/superlu: Update to version 5.1.1
Summary: [PATCH] math/superlu: Update to version 5.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-patch, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-10-01 18:32 UTC by tkato432
Modified: 2016-03-17 18:55 UTC (History)
4 users (show)

See Also:

Attachments
math_superlu.diff (15.03 KB, patch)
2015-10-01 18:32 UTC, tkato432 		no flags Details | Diff
math_superlu.diff (16.52 KB, patch)
2015-12-06 11:30 UTC, tkato432 		koobs: maintainer-approval+
Details | Diff
math_superlu.diff (16.52 KB, patch)
2016-01-08 17:30 UTC, tkato432 		koobs: maintainer-approval+
Details | Diff
math_superlu.diff (15.46 KB, patch)
2016-01-25 09:30 UTC, tkato432 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2015-10-01 18:32:07 UTC 
Created attachment 161615 [details]
math_superlu.diff
Comment 1 tkato432 2015-12-06 11:30:29 UTC 
Created attachment 163892 [details]
math_superlu.diff

Version 5.1 has been released.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-06 11:33:17 UTC 
Comment on attachment 163892 [details]
math_superlu.diff

Port is un-maintained, implicit approval
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2015-12-30 07:17:06 UTC 
Did they re-roll the distfile?

=> Attempting to fetch http://crd-legacy.lbl.gov/~xiaoye/SuperLU/superlu_5.1.tar.gz
fetch: http://crd-legacy.lbl.gov/~xiaoye/SuperLU/superlu_5.1.tar.gz: size mismatch: expected 2563623, actual 2562892
Comment 4 tkato432 2015-12-31 13:01:03 UTC 
Oh, it would appear so.

diff -urN old/SuperLU_5.1/SRC/util.c new/SuperLU_5.1/SRC/util.c
--- old/SuperLU_5.1/SRC/util.c	2015-07-25 05:39:53.000000000 +0000
+++ new/SuperLU_5.1/SRC/util.c	2015-12-18 20:37:31.000000000 +0000
@@ -29,7 +29,7 @@
 
 void superlu_abort_and_exit(char* msg)
 {
-    fprintf(stderr, msg);
+    fprintf(stderr, "%s", msg);
     exit (-1);
 }
 
diff -urN old/SuperLU_5.1/make.inc new/SuperLU_5.1/make.inc
--- old/SuperLU_5.1/make.inc	2015-12-03 23:27:55.000000000 +0000
+++ new/SuperLU_5.1/make.inc	2015-12-04 01:06:38.000000000 +0000
@@ -21,7 +21,7 @@
 #
 #  The name of the libraries to be created/linked to
 #
-SuperLUroot	= $(HOME)/Dropbox/Codes/SuperLU/SuperLU_5.1
+SuperLUroot	= $(HOME)/Dropbox/Codes/SuperLU/SuperLU
 SUPERLULIB   	= $(SuperLUroot)/lib/libsuperlu_5.1.a
 
 #BLASLIB   	= $(SuperLUroot)/lib/libblas.a
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2016-01-03 10:11:10 UTC 
(In reply to tkato432 from comment #4)

With the new tarball the build fails:
...
=> Patch patch-make.inc failed to apply cleanly.

Can you resubmit a working patch against the new distfile?
Comment 6 tkato432 2016-01-08 17:30:10 UTC 
Created attachment 165270 [details]
math_superlu.diff

Adjusted to the latest tarball.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-08 17:40:04 UTC 
Comment on attachment 165270 [details]
math_superlu.diff

Port is unmaintained, implicit approval
Comment 8 Thierry Thomas freebsd_committer freebsd_triage 2016-01-23 21:00:19 UTC 
According to http://crd.lbl.gov/~xiaoye/SuperLU/ it has been upgraded to 5.1.1.
Comment 9 tkato432 2016-01-25 09:30:17 UTC 
Created attachment 166087 [details]
math_superlu.diff

Version 5.1.1 has been released.
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-03-08 15:55:27 UTC 
A commit references this bug:

Author: mat
Date: Tue Mar  8 15:55:13 UTC 2016
New revision: 410620
URL: https://svnweb.freebsd.org/changeset/ports/410620

Log:
  Update to 5.1.1.

  PR:		203482
  Submitted by:	tkato432 yahoo com
  Sponsored by:	Absolight

Changes:
  head/math/superlu/Makefile
  head/math/superlu/distinfo
  head/math/superlu/files/
  head/math/superlu/pkg-descr
  head/math/superlu/pkg-plist
Comment 11 John Marino freebsd_committer freebsd_triage 2016-03-10 21:26:45 UTC 
mat, this broke arpack++ everywhere

specifically, arpark++ specifies lib/libsuperlu.a which this commit removed

http://portsmon.freebsd.org/portoverview.py?category=math&portname=arpack%2B%2B
Comment 12 John Marino freebsd_committer freebsd_triage 2016-03-13 12:18:59 UTC 
cad/tochnog is broken because of this commit too.

I'm reopening the PR.
Comment 13 Jan Beich freebsd_committer freebsd_triage 2016-03-17 18:54:12 UTC 
ports r411007 fixed comment 12 and ports r411034 fixed comment 11. Unless you
Comment 14 John Marino freebsd_committer freebsd_triage 2016-03-17 18:55:43 UTC 
thx