Bug 203581 - [new port] databases/rubygem-after_commit_queue
Summary: [new port] databases/rubygem-after_commit_queue
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks: 203620
  Show dependency treegraph
 
Reported: 2015-10-06 11:45 UTC by Michael Fausten
Modified: 2015-11-23 18:47 UTC (History)
1 user (show)

See Also:


Attachments
rubygem-after_commit_queue shar file (1.59 KB, text/plain)
2015-10-06 11:45 UTC, Michael Fausten
no flags Details
rubygem-after_commit_queue shar file new (1.68 KB, patch)
2015-10-06 19:39 UTC, Michael Fausten
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Fausten 2015-10-06 11:45:58 UTC
Created attachment 161757 [details]
rubygem-after_commit_queue shar file

This port will be needed as a runtime dependency for the new www/gitlab 8 port, 
which Torsten Zühlsdorff is currently creating. 
Before sending this PR, he tested the new version against this dependency.
Comment 1 Michael Fausten 2015-10-06 19:39:07 UTC
Created attachment 161773 [details]
rubygem-after_commit_queue shar file new

Sorry, the first file was incomplete.
Comment 2 Torsten Zühlsdorff 2015-10-07 08:57:57 UTC
I didn't test this port. ;) And also it is not working.

You should be able to reproduce it by doing the following steps:

# cd /usr/ports/databases/rubygem-after_commit_queue
# make install
$ irb

irb(main):001:0> require 'after_commit_queue'
NameError: uninitialized constant AfterCommitQueue::ActiveSupport
        from /usr/local/lib/ruby/gems/2.1/gems/after_commit_queue-1.3.0/lib/after_commit_queue.rb:2:in `<module:AfterCommitQueue>'
        from /usr/local/lib/ruby/gems/2.1/gems/after_commit_queue-1.3.0/lib/after_commit_queue.rb:1:in `<top (required)>'
        from /usr/local/lib/ruby/site_ruby/2.1/rubygems/core_ext/kernel_require.rb:128:in `require'
        from /usr/local/lib/ruby/site_ruby/2.1/rubygems/core_ext/kernel_require.rb:128:in `rescue in require'
        from /usr/local/lib/ruby/site_ruby/2.1/rubygems/core_ext/kernel_require.rb:39:in `require'
        from (irb):1
        from /usr/local/bin/irb:11:in `<main>'
Comment 3 Torsten Zühlsdorff 2015-10-07 09:02:21 UTC
Mh, after some better reading of the documentation, i assume my test is wrong. 

But i didn't test the port in the first place. Have you test it in any way Michael?
Comment 4 Michael Fausten 2015-10-07 12:19:53 UTC
Yes, this is the only port you didn't test. Sorry, my bad.

As I did for each port, I did all the testing the porters handbook suggests.
Anyway, trying to load the gem in irb gives me the exact same error.

Any ideas how to fix this?
Comment 5 Torsten Zühlsdorff 2015-10-07 12:48:03 UTC
So, after some more reading of documentation, i can confirm, that this port works. I've used the example from the homepage of the gem, to check if it works. It does. It is just wrong to simply require the gem. You need to include it at the correct code position.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-11-23 18:26:57 UTC
A commit references this bug:

Author: sunpoet
Date: Mon Nov 23 18:26:37 UTC 2015
New revision: 402299
URL: https://svnweb.freebsd.org/changeset/ports/402299

Log:
  - Add rubygem-after_commit_queue 1.3.0
  - While I'm here:
    - Add LICENSE_FILE
    - Add NO_ARCH

  Plugin for running methods on ActiveRecord models after record is committed

  WWW: https://github.com/shellycloud/after_commit_queue

  PR:		203581
  Submitted by:	Michael Fausten <ports@michael-fausten.de>

Changes:
  head/databases/Makefile
  head/databases/rubygem-after_commit_queue/
  head/databases/rubygem-after_commit_queue/Makefile
  head/databases/rubygem-after_commit_queue/distinfo
  head/databases/rubygem-after_commit_queue/pkg-descr
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-11-23 18:47:01 UTC
New port added. Thanks!