Bug 203769 - [patch] databases/pgpool: Update to 3.4.3, Take MAINTAINER'ship
Summary: [patch] databases/pgpool: Update to 3.4.3, Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-10-14 13:50 UTC by Torsten Zühlsdorff
Modified: 2015-11-15 03:04 UTC (History)
0 users

See Also:


Attachments
path with update pgpool to 3.4.3 (2.78 KB, patch)
2015-10-14 13:50 UTC, Torsten Zühlsdorff
no flags Details | Diff
poudriere log (95.48 KB, text/x-log)
2015-10-14 13:50 UTC, Torsten Zühlsdorff
no flags Details
path with update pgpool to 3.4.3 - version 2 (3.73 KB, patch)
2015-10-21 13:21 UTC, Torsten Zühlsdorff
no flags Details | Diff
poudriere log for version 2 (98.06 KB, text/x-log)
2015-10-21 13:21 UTC, Torsten Zühlsdorff
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2015-10-14 13:50:15 UTC
Created attachment 162038 [details]
path with update pgpool to 3.4.3

I wrote a patch for databases/pgpool with the following changes:
- update to 3.4.3
- become maintainer
- change MASTERSITE
- change homepage because project moved
- honor stripping of new lib installed

There are a number of similar ports for pgpool. I will have a look at them in the future.
Comment 1 Torsten Zühlsdorff 2015-10-14 13:50:41 UTC
Created attachment 162039 [details]
poudriere log
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-16 14:14:16 UTC
> LIB_DEPENDS=	libpq.so:${PORTSDIR}/databases/postgresql93-client

Please use USES=pgsql instead

> PORTDOCS=	README AUTHORS COPYING ChangeLog INSTALL NEWS TODO

Please do not install COPYING (handled by LICENSE, you could also add LICENSE_FILE), INSTALL (not needed as installation is done by the port) and README (empty apart from reference to doc/, which you probably should install)

> %%ETCDIR%%.conf.sample

This is incorrect usage of ETCDIR, as it does not really mean directory here. Better use plain etc/pgpool.conf.sample. Consider using @sample if default configs make any sense.

> %%DATADIR%%-II/insert_lock.sql

Better define DATADIR=${PREFIX}/share/${PORTNAME}-II and use %%DATADIR%%/ in plis

> ${INSTALL_MAN} ${WRKSRC}/$f ${STAGEDIR}${DOCSDIR}

This is incorrect, should use INSTALL_DATA.
Comment 3 Torsten Zühlsdorff 2015-10-20 08:58:49 UTC
Hello Dmitry,

i'm working on your suggestions. I've also stumbled over a bug in the pgsql Uses-Script which i'm currently fixing.

I will update the patch when i am done. 

Thanks and Greetings,
Torsten
Comment 4 Torsten Zühlsdorff 2015-10-21 13:21:00 UTC
Created attachment 162283 [details]
path with update pgpool to 3.4.3 - version 2
Comment 5 Torsten Zühlsdorff 2015-10-21 13:21:31 UTC
Created attachment 162284 [details]
poudriere log for version 2
Comment 6 Torsten Zühlsdorff 2015-10-21 13:25:00 UTC
Hello Dmitry,

i followed most of your suggestions. I did not get PORTDOCS to work as i want; i know this and will have a look later at it.

Also %%ETCDIR%% confuses me, because this was generated by make makeplist. But it is rewritten now. Same for %%DATADIR%%.

I also make one of the configurations files a sample and made it work. For this i also added a pkg-message, because two steps are needed before pgpool can start.

Greetings,
Torsten
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2015-11-15 03:03:02 UTC
Committed with minor changes:
- Use DATADIR
- Install more docs
- Add LICENSE_FILE
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-11-15 03:03:40 UTC
A commit references this bug:

Author: amdmi3
Date: Sun Nov 15 03:02:59 UTC 2015
New revision: 401653
URL: https://svnweb.freebsd.org/changeset/ports/401653

Log:
  - Update to 3.4.3
  - Pass maintainership to submitter
  - Update MASTERSITE and www
  - Strip library

  PR:		203769
  Submitted by:	ports@toco-domains.de

Changes:
  head/databases/pgpool/Makefile
  head/databases/pgpool/distinfo
  head/databases/pgpool/pkg-descr
  head/databases/pgpool/pkg-plist
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-11-15 03:04:41 UTC
A commit references this bug:

Author: amdmi3
Date: Sun Nov 15 03:04:15 UTC 2015
New revision: 401664
URL: https://svnweb.freebsd.org/changeset/ports/401664

Log:
  - Add forgotten pkg-message

  PR:		203769
  Submitted by:	ports@toco-domains.de

Changes:
  head/databases/pgpool/pkg-message