Bug 203872 - [NEW PORT] chinese/gydict: Command line tool of Yahoo! Dictionary
Summary: [NEW PORT] chinese/gydict: Command line tool of Yahoo! Dictionary
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords: feature, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-10-19 16:06 UTC by Sean Chang
Modified: 2016-01-04 09:05 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
shell archive of gydict (1.56 KB, application/x-shar)
2015-10-19 16:06 UTC, Sean Chang 		no flags Details
shell archive of gydict (updated) (1.50 KB, application/x-shar)
2015-10-20 04:44 UTC, Sean Chang 		no flags Details
portlint output of gydict (90 bytes, text/plain)
2015-10-20 04:59 UTC, Sean Chang 		no flags Details
poudriere testport of gydict (13.83 KB, text/plain)
2015-10-20 05:34 UTC, Sean Chang 		no flags Details
shell archive of gydict (with secondary categories) (1.52 KB, application/x-shar)
2015-10-20 06:04 UTC, Sean Chang 		koobs: maintainer-approval+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Chang 2015-10-19 16:06:24 UTC 
Created attachment 162209 [details]
shell archive of gydict

Re-implement deprecated chinese/ydict with Python3.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-20 03:26:34 UTC 
@Sean, on initial review:

* Use USES=python:[run,<version>] to declare a dependency on Python. See /usr/ports/Mk/Uses/python.mk for more details
* You may want to consider a more specific primary category than 'chinese'. Something like <category> chinese python. Is the ports functionality for instance limited to the Chinese version of the Yahoo! dictionary?
* GH_PROJECT defaults to PORTNAME, and is unnecessary
* PLIST_FILES value shouldnt need a PREFIX

Please also run this port through QA (portlint, poudriere) to ensure it passes, fixing any reported issues, and then update the attachment here.
Comment 2 Sean Chang 2015-10-20 04:44:20 UTC 
Created attachment 162224 [details]
shell archive of gydict (updated)

- Fix the dependency on Python
- Remove GH_PROJECT
- PLIST_FILES without PREFIX
Comment 3 Sean Chang 2015-10-20 04:54:18 UTC 
(In reply to Kubilay Kocak from comment #1)

The functionality of the port is actually limited in Chinese to English and English to Chinese translation. And it parses the contents from Chinese version of Yahoo! Dictionary. So I believe put it in chinese category is appropriate.

This is my first time submitting a port. I'll do my best. Thank you for your comments.
Comment 4 Sean Chang 2015-10-20 04:59:19 UTC 
Created attachment 162225 [details]
portlint output of gydict
Comment 5 Sean Chang 2015-10-20 05:34:26 UTC 
Created attachment 162226 [details]
poudriere testport of gydict
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-20 05:47:10 UTC 
@Sean, thanks for the update, though I would still recommend adding textproc and python as secondary categories.
Comment 7 Sean Chang 2015-10-20 06:04:31 UTC 
Created attachment 162228 [details]
shell archive of gydict (with secondary categories)
Comment 8 Sean Chang 2015-10-25 17:27:27 UTC 
Sorry for my ignorance, is there something I should do for this port to be committed now? I'm not familiar with the workflow after the flag (maintainer-approval+) set up.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-26 01:06:21 UTC 
@Sean, nothing else needed from your side that I can see :)
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-01-04 09:05:04 UTC 
A commit references this bug:

Author: miwi
Date: Mon Jan  4 09:04:29 UTC 2016
New revision: 405224
URL: https://svnweb.freebsd.org/changeset/ports/405224

Log:
  A command line tool to do EN <-> CH translation, utilized by Yahoo! Dictionary.

  WWW: https://github.com/iamgyz/gydict

  PR:		203872
  Submitted by:	Chih-Hsin Chang <chihhsin@cs.nctu.edu.tw>

Changes:
  head/chinese/Makefile
  head/chinese/gydict/
  head/chinese/gydict/Makefile
  head/chinese/gydict/distinfo
  head/chinese/gydict/pkg-descr