Bug 203972 - [patch] net/uriparser: Update to 0.8.4
Summary: [patch] net/uriparser: Update to 0.8.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ed Schouten
URL:
Keywords: patch
Depends on:
Blocks: 203949
  Show dependency tree / graph
 
Reported: 2015-10-23 08:34 UTC by Torsten Zühlsdorff
Modified: 2015-10-27 07:35 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ed)

Attachments
Patch with update to version 0.8.4 (2.42 KB, patch)
2015-10-23 08:34 UTC, Torsten Zühlsdorff 		no flags Details | Diff
poudriere log (32.07 KB, text/x-log)
2015-10-23 08:34 UTC, Torsten Zühlsdorff 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2015-10-23 08:34:14 UTC 
Created attachment 162377 [details]
Patch with update to version 0.8.4

Hello,

attached a patch to bump the library to the newest version. While there i defined the License too.

Attention: i needed to create a patch in order to make the port compiling. But my C experience is quite old, therefore please have a closer look at what i had done :D

As side-result portlint is now happy:
# portlint -C
looks fine.

Greetings,
Torsten
Comment 1 Torsten Zühlsdorff 2015-10-23 08:34:38 UTC 
Created attachment 162378 [details]
poudriere log
Comment 2 Ed Schouten freebsd_committer freebsd_triage 2015-10-26 19:32:52 UTC 
Hi Torsten,

Thanks for the patch! I just took a look at it. I can also reproduce the build failure. Looking at the compiler error, I think we can simplify the patch slightly. We only need to #include <sys/socket.h> to get AF_INET/AF_INET6.

I just sent out a code review to bapt@, as I typically run patches past him.

https://reviews.freebsd.org/D4001
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-10-27 07:34:17 UTC 
A commit references this bug:

Author: ed
Date: Tue Oct 27 07:33:47 UTC 2015
New revision: 400218
URL: https://svnweb.freebsd.org/changeset/ports/400218

Log:
  Update uriparser to version 0.8.4.

  It looks like the latest release doesn't build because of a missing
  #include. The source file depends on AF_INET and AF_INET6, which of
  course requires <sys/socket.h>.

  Submitted by: Torsten Z?hlsdorff
  PR: 203972
  Differential Revision:	https://reviews.freebsd.org/D4001

Changes:
  head/net/uriparser/Makefile
  head/net/uriparser/distinfo
  head/net/uriparser/files/
  head/net/uriparser/files/patch-tool_uriparse.c
  head/net/uriparser/pkg-plist
Comment 4 Ed Schouten freebsd_committer freebsd_triage 2015-10-27 07:35:01 UTC 
Committed as r400218. Thanks!