Bug 204052 - print/p5-Net-CUPS: Should remove broken, version check needs patching
Summary: print/p5-Net-CUPS: Should remove broken, version check needs patching
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Veniamin Gvozdikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-27 10:14 UTC by Mathieu Simon
Modified: 2015-11-07 11:19 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (vg)

Attachments
Adds patch for work around now-erroneous version check (1.90 KB, application/mbox)
2015-10-27 10:14 UTC, Mathieu Simon 		no flags Details
Fix version check logic for current CUPS versions (1.95 KB, patch)
2015-10-27 12:30 UTC, Mathieu Simon 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Simon 2015-10-27 10:14:22 UTC 
Created attachment 162492 [details]
Adds patch for work around now-erroneous version check

Dear Maintainer

The version check in Makefile.PL is broken for any version with a second digit of 0, thus erroneously fails with i.e. CUPS 2.0.3.

This adds a extra if clause that it should only check further if the first version digit is less than 2.

The upstream bug reference is here but still unfixed and the auhtor hasn't reacted to the bug report by another person:

https://rt.cpan.org/Public/Bug/Display.html?id=104237

See the attached diff, let me know if that's OK for the ports tree.
Comment 1 Mathieu Simon 2015-10-27 12:30:14 UTC 
Created attachment 162495 [details]
Fix version check logic for current CUPS versions

Upstream bug tracker notified, the previous patch was really just a band aid.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-11-07 11:18:27 UTC 
A commit references this bug:

Author: vg
Date: Sat Nov  7 11:18:12 UTC 2015
New revision: 400978
URL: https://svnweb.freebsd.org/changeset/ports/400978

Log:
  - Remove broken
  - Fix build

  PR:		ports/204052
  Submitted by:	Mathieu Simon <freebsd@simweb.ch>

Changes:
  head/print/p5-Net-CUPS/Makefile
  head/print/p5-Net-CUPS/files/patch-Makefile.PL
Comment 3 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-11-07 11:19:26 UTC 
Committed, thank you!