Created attachment 162512 [details] Shar file Puppet Server running in the JVM.
take
I finally did test this, some comments: - please add ">=0" also to the run dependencies and use puppet4 instead of puppet - puppetserver didn't start for me, because the JRE can't cope with the /nonexistant home dir of the puppet user, after adding "HOME=/tmp" to the rc script it started. - I'm unsure how to deal with facter and its path. /usr/local/lib/ruby/vendor_ruby would work for facter3, so maybe a symlink from there to the files of rubygem-facter would solve this, but I don't know if that has side effects and that would need to go into sysutils/rubygem-facter - Instead of 2.1 ${RUBY_VER} should be used. - As this port could use facter3, please implement an option for the facter 2/3 selection, like in sysutils/puppet4 I'd like to get puppetserver in first and look at PuppetDB (and puppetdb-termini) after that.
Created attachment 163493 [details] Shar file with first round of feedback addressed This should address most of the issues raised here, save for the facter paths. I tested it out in a poudriere jail and the service came online for me. Though I believe I tested that previously, I added the HOME=/tmp to the rc script anyway. We can always adjust later if needed.
Have you had a chance to review the changes here? The puppetdb3 port is falling behind and I'd like to make progress on these if I can. Anything I can do to help, just let me know.
Not really, sorry... I was also hoping to come up with better workarounds for some of the problems mentioned, however, I think as there will be no more facter 2.x releases, the version can stay hardcoded without causing too much trouble. Regarding the $HOME problem related to Java, I still have no idea if there's a better way to solve that. Anyway, the changes of the second patch are looking good, but I'd like to get more eyes on it, could you open a review at https://reviews.freebsd.org/differential? If not, I can also open it. It would be nice to have this updated to the latest puppetserver version.
back to pool
Xaque208, thanks for the submission. Does attachment "Shar file with first round of feedback addressed" from comment #3 obsolete the original attachment?
Hi yes. The latest shar replaces the original. I can bump to the latest version of puppetserver if that would help, but I'd rather not sink time into something that won't help get this moved along. If this can get in, I can submit a follow up maintenance to bump the version to the latest, whatever that is at the time. I'll be looking to use this port internally from my own tree due to the amount of time this is taking to get in. I also have an outstanding puppetdb3 port that is pending review. These two will be used in conjunction. If there is anything that needs to be addressed here, please don't hesitate to shout. Thank you.
Can't be in progress without an Assignee. Open to take @Xaque, can you confirm this passes QA (portlint, poudriere) please?
I'm going to bump the version to the latest this week before confirming. I'll get all that working and then request review.
Created attachment 166072 [details] puppetserver2.2.1 Here is an updated port version. It passes testport from poudriere, and logging into the tested jail, I'm able to start the service. Logs and functions as expected with a minimal test.
Is there anything I can help with here to get this moved along?
portlint(ok) WARN: /usr/local/poudriere/ports/xaque208/sysutils/puppetserver/pkg-descr: includes lines that exceed 80 characters. 0 fatal errors and 1 warning found.
testbuilds@work Btw, the .shar had some strange syntax issues (the second to last line were indented by one space char, and the lines had ctrl-M at the end).
Testbuilds are fine.
A commit references this bug: Author: pi Date: Sat Mar 12 14:30:02 UTC 2016 New revision: 410891 URL: https://svnweb.freebsd.org/changeset/ports/410891 Log: New port: sysutils/puppetserver Puppet master is a Ruby application that compiles configurations for any number of Puppet agent nodes, using Puppet code and various other data sources. (For more info, see Overview of Puppet's Architecture.) Puppet Server is an application that runs on the Java Virtual Machine (JVM) and provides the same services as the classic Puppet master application. It mostly does this by running the existing Puppet master code in several JRuby interpreters, but it replaces some parts of the classic application with new services written in Clojure. WWW: https://docs.puppetlabs.com/puppetserver/latest/services_master_puppetserver.html PR: 204072 Submitted by: Zach Leslie <freebsd@zleslie.info> Changes: head/sysutils/Makefile head/sysutils/puppetserver/ head/sysutils/puppetserver/Makefile head/sysutils/puppetserver/distinfo head/sysutils/puppetserver/files/ head/sysutils/puppetserver/files/patch-ext__config__conf.d__global.conf head/sysutils/puppetserver/files/patch-ext__config__conf.d__puppetserver.conf head/sysutils/puppetserver/files/patch-ext__config__conf.d__webserver.conf head/sysutils/puppetserver/files/patch-ext__config__logback.xml head/sysutils/puppetserver/files/patch-ext__config__request-logging.xml head/sysutils/puppetserver/files/pkg-message.in head/sysutils/puppetserver/files/puppetserver.in head/sysutils/puppetserver/pkg-descr head/sysutils/puppetserver/pkg-plist
Committed, thanks. And sorry that it took so long!