Bug 204090 - [patch] security/strongswan: Add VICI option and mark SMP as deprecated
Summary: [patch] security/strongswan: Add VICI option and mark SMP as deprecated
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Renato Botelho
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-10-28 13:07 UTC by Renato Botelho
Modified: 2015-10-28 14:29 UTC (History)
1 user (show)

See Also:
strongswan: maintainer-feedback+

Attachments
Add VICI and deprecate SMP (2.22 KB, patch)
2015-10-28 13:07 UTC, Renato Botelho 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho freebsd_committer freebsd_triage 2015-10-28 13:07:35 UTC 
Created attachment 162531 [details]
Add VICI and deprecate SMP

Since version 5.2.0, SMP plugin is deprecated - https://wiki.strongswan.org/projects/strongswan/wiki/SMP

Mark OPTION description as DEPRECATED to let user know and add VICI, the current substitute to smp.
Comment 1 Francois ten Krooden 2015-10-28 14:23:59 UTC 
I'm happy see no issues with this change.
Just not sure if we have to bump the port revision with this change.
Otherwise the patch can be applied.
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2015-10-28 14:25:50 UTC 
(In reply to strongswan from comment #1)
We don't need to bump PORTREVISION since neither SMP or VICI are enabled by default
Comment 3 Renato Botelho freebsd_committer freebsd_triage 2015-10-28 14:28:10 UTC 
Sponsored by: Rubicon Communications (Netgate)
Obtained from: pfSense
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-10-28 14:28:26 UTC 
A commit references this bug:

Author: garga
Date: Wed Oct 28 14:27:28 UTC 2015
New revision: 400393
URL: https://svnweb.freebsd.org/changeset/ports/400393

Log:
  - Add a new option (VICI) to build VICI management protocol
  - Change SMP option description to show users it's deprecated

  PR:		204090
  Approved by:	maintainer

Changes:
  head/security/strongswan/Makefile
  head/security/strongswan/pkg-plist