Bug 204145 - sysutils/tuptime: Does not require linprocfs
Summary: sysutils/tuptime: Does not require linprocfs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-10-30 13:30 UTC by RicardoF
Modified: 2015-11-22 08:03 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
Correct pkg-message.in and install upgrade scripts for older databases. (2.23 KB, patch)
2015-11-01 05:25 UTC, Jeremy Johnston 		jeremy: maintainer-approval+
Details | Diff
poudriere testport output (17.57 KB, text/x-log)
2015-11-01 05:39 UTC, Jeremy Johnston 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description RicardoF 2015-10-30 13:30:32 UTC 
When installing sysutils/tuptime on a system, the following advert message is printed:

======================================================================

tuptime requires linprocfs(5) mounted under /compat/linux/proc.

If you have not done it yet, please do the following:

	mkdir -p /usr/compat/linux/proc; ln -sf usr/compat /compat
	mount -t linprocfs linprocfs /compat/linux/proc

To make it permanent, you need the following lines in /etc/fstab:

	linproc	/compat/linux/proc	linprocfs	rw,late		0	0

tuptime also requires the following be added to /etc/crontab:

	*/5 * * * * root test -x /usr/local/bin/tuptime && /usr/local/bin/tuptime -x > /dev/null

======================================================================

The 3.2.01 version doesn't require linprocfs because it retrieves kernel state trought sysctl.
Comment 1 Jeremy Johnston 2015-10-31 00:40:51 UTC 
This was an oversight when the committer updated the port before committing it into the freebsd tree. I have added a patch to the original PR (203079) that corrects this and a few other minor changes to the port.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-31 04:25:10 UTC 
@Jeremy what was your intended meaning for setting maintainer-feedback to "-" ?

It this issue addressed by bug 203079? 

If so, this issue can depend on it.
Comment 3 Jeremy Johnston 2015-10-31 16:12:13 UTC 
(In reply to Kubilay Kocak from comment #2) Mis-click on my part, this bug should depend on 203079
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-31 18:01:46 UTC 
Thanks Jeremy. Bug 203079 has been set as a dependency, and it appears closed. 

Does that mean this issue can now be closed?
Comment 5 Jeremy Johnston 2015-11-01 04:54:27 UTC 
(In reply to Kubilay Kocak from comment #4) I had replied to the bug report and thought it would automatically re-open the bug but apparently this is not how bugzilla works. I attached a patch to the previous bug report that needs to be applied that corrects the pkg-message and installs the db upgrade scripts that are included in newer versions that were not included when I first created the port.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-01 05:07:59 UTC 
Please obsolete the patch there and add the attachment here, since the original one is closed.
Comment 7 Jeremy Johnston 2015-11-01 05:25:55 UTC 
Created attachment 162665 [details]
Correct pkg-message.in and install upgrade scripts for older databases.

Correct pkg-message.in and install upgrade scripts for older databases.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-01 05:29:18 UTC 
Thanks Jeremy, can you confirm this passes QA? (portlint/poudriere testport)
Comment 9 Jeremy Johnston 2015-11-01 05:39:03 UTC 
Created attachment 162666 [details]
poudriere testport output
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2015-11-22 08:02:56 UTC 
Committed, thanks.
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-11-22 08:03:22 UTC 
A commit references this bug:

Author: pi
Date: Sun Nov 22 08:02:42 UTC 2015
New revision: 402218
URL: https://svnweb.freebsd.org/changeset/ports/402218

Log:
  sysutils/tuptime: small fixes

  - correct pkg-message and install upgrade scripts for older databases

  PR:		204145
  Submitted by:	ricardo.fraile@gmail.com
  Approved by:	jeremy@smart-serv.net (maintainer)

Changes:
  head/sysutils/tuptime/Makefile
  head/sysutils/tuptime/files/pkg-message.in