Bug 204171 - [PATCH] audio/kstreamripper: update to 0.7.100
Summary: [PATCH] audio/kstreamripper: update to 0.7.100
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Raphael Kubo da Costa
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-10-30 23:07 UTC by Matthew Rezny
Modified: 2016-01-03 13:12 UTC (History)
4 users (show)

See Also:
rakuco: maintainer-feedback-


Attachments
audio/kstreamripper update to 0.7.100 (2.01 KB, patch)
2015-10-30 23:07 UTC, Matthew Rezny
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer freebsd_triage 2015-10-30 23:07:31 UTC
Created attachment 162625 [details]
audio/kstreamripper update to 0.7.100

Resolve unfetchable by updating to latest release. WITHOUT_LIBPROXY seems not to be needed anymore, it builds fine without and the result is not linked to libproxy.so.
Comment 1 Jonathan Chu freebsd_committer freebsd_triage 2015-11-25 07:10:52 UTC
Maintainer timeout.


I've submitted your patch for review: https://reviews.freebsd.org/D4272
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2016-01-01 20:17:08 UTC
I explicitly did not remove this port because of this PR and the Phabricator review, but it fell victim to http://svnweb.freebsd.org/changeset/ports/404989
Comment 3 Matthew Rezny freebsd_committer freebsd_triage 2016-01-02 03:09:36 UTC
I put this PR in before the expiration date because I was told that ports with outstanding PRs would not be removed. I guess that was a lie.

It is highly annoying that this has sat for over 2 months with no meaningful action, but it is par for the course in ports land. The creation of a review after the maintainer timeout puzzles me, just one more piece in a process that moves at a glacier pace.

I expect the patch to be promptly committed, or r404989 to be immediately reverted and some action taken on that review. To leave the current state is basically a giant "fuck you and your time" to this contributor.
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2016-01-02 12:20:38 UTC
Although I did not delete this port, I will see it being resurrected and patched.
Comment 5 Matthew Rezny freebsd_committer freebsd_triage 2016-01-02 13:07:32 UTC
(In reply to Rene Ladan from comment #4)

Rene: Thank you for taking that responsibility. I want to be sure it is clear that my prior comment was in no way directed to you personally as I am aware you did not do the delete. The comment was on the overall disorganization.
Comment 6 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-01-03 00:56:14 UTC
I will test the update in 9.3 tomorrow and ressurrect the port. Sorry for the confusion, it's unfortunate that this fell through the cracks in Bugzilla.
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-01-03 13:04:58 UTC
A commit references this bug:

Author: rakuco
Date: Sun Jan  3 13:04:18 UTC 2016
New revision: 405139
URL: https://svnweb.freebsd.org/changeset/ports/405139

Log:
  Ressurrect audio/kstreamripper and update to 0.7.100.

  Update to the latest release to make the port fetchable again. Stop passing
  -DWITHOUT_LIBPROXY=YES to CMake because upstream disabled libproxy support a
  few releases ago.

  PR:		204171
  Submitted by:	matthew@reztek.cz
  Approved by:	maintainer timeout (65 days)

Changes:
  head/MOVED
  head/audio/Makefile
  head/audio/kstreamripper/
  head/audio/kstreamripper/Makefile
  head/audio/kstreamripper/distinfo
  head/audio/kstreamripper/pkg-plist
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-01-03 13:09:01 UTC
A commit references this bug:

Author: rakuco
Date: Sun Jan  3 13:08:19 UTC 2016
New revision: 405140
URL: https://svnweb.freebsd.org/changeset/ports/405140

Log:
  MFH: r405139

  Ressurrect audio/kstreamripper and update to 0.7.100.

  Update to the latest release to make the port fetchable again. Stop passing
  -DWITHOUT_LIBPROXY=YES to CMake because upstream disabled libproxy support a
  few releases ago.

  PR:		204171
  Submitted by:	matthew@reztek.cz
  Approved by:	maintainer timeout (65 days)

  Approved by:	portmgr blanket

Changes:
_U  branches/2016Q1/
  branches/2016Q1/MOVED
  branches/2016Q1/audio/Makefile
  branches/2016Q1/audio/kstreamripper/
Comment 9 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-01-03 13:12:47 UTC
Finally landed. Thanks a lot for your contributions, they are highly appreciated despite occasional setbacks like this one.