Created attachment 162862 [details] net/asterisk-chan_sccp directory SCCP channel driver in Asterisk Extended features include (amongst others): - Shared Lines, - Customizable Feature Buttons, - Custom Device State. - Conference with Phone-UI - Different CallerID's per Shared Line - Realtime Config - Module Reload (processes changes in sccp.conf) - Advanced busy lamp field support (BLF) (with Advanced Presence) - Adhoc Dialing a.k.a. Private line automatic ringdown (PLAR) - Hotline Functionality - Dynamic Speeddials - Video Calls - IPV6 Support Sourceforge: https://sourceforge.net/projects/chan-sccp-b/ License: GPLv1 Release: Stable v4.1.0
why this? ".include <bsd.port.pre.mk>" why is PORTREVISION set on a new port? (it shouldn't be) portlint output? checked by poudriere?
I am a little new to writing ports for FreePBX. So please be lenient :-) > why this? > ".include <bsd.port.pre.mk>" I think i copied it from asterisk-g72x > why is PORTREVISION set on a new port? (it shouldn't be) Sorry about that. Should i remove the line completely ? > portlint output? Output from portlint was clean. Except for warning about COMMENT (Telling me to use a Capital at the beginning of the line and a period at the end, which i did), So i left that warning for what it was. > checked by poudriere? Did not check poudriere, it did not tell me to do so on the wiki page (i think). I can make any changes you would like me to make and run de tests that need to be run.
Removed the PORTREVISION as requested Removing: .include <bsd.port.pre.mk> Produces: make: "/usr/ports/Mk/bsd.ssp.mk" line 7: Malformed conditional (${OSVERSION} < 1000036 && ${ARCH} == i386) make: "/usr/ports/Mk/bsd.ssp.mk" line 20: Malformed conditional (!defined(SSP_UNSAFE) && (${ARCH} == i386 || ${ARCH} == amd64)) make: "/usr/ports/Mk/bsd.port.mk" line 1675: Malformed conditional (${ARCH} == "amd64" || ${ARCH} =="ia64") make: "/usr/ports/Mk/bsd.port.mk" line 1705: Malformed conditional (${WITH_PKG} == devel) make: "/usr/ports/Mk/bsd.port.mk" line 2128: Malformed conditional (${PREFIX} == /usr) make: "/usr/ports/Mk/bsd.port.mk" line 2679: Malformed conditional (${PREFIX} == /usr) make: "/usr/ports/Mk/bsd.port.mk" line 2692: Malformed conditional (${PREFIX} == /usr) make: "/usr/ports/Mk/bsd.port.mk" line 3343: Malformed conditional (${OSVERSION} >= 1000000 && !defined(WITHOUT_FBSD10_FIX)) make: "/usr/ports/Mk/bsd.port.mk" line 3933: Malformed conditional (${UID} != 0 && !defined(INSTALL_AS_USER)) make: "/usr/ports/Mk/bsd.port.mk" line 4953: Malformed conditional ((${PREFIX} != ${LOCALBASE} && ${PREFIX} != ${LINUXBASE} && ${PREFIX} != "/usr" && !defined(NO_PREFIX_RMDIR))) make: "/usr/ports/Mk/bsd.port.mk" line 5796: Malformed conditional (${UID} != 0 && defined(_${:Uextract:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER)) make: "/usr/ports/Mk/bsd.port.mk" line 5796: Malformed conditional (${UID} != 0 && defined(_${:Upatch:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER)) make: "/usr/ports/Mk/bsd.port.mk" line 5796: Malformed conditional (${UID} != 0 && defined(_${:Uconfigure:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER)) make: "/usr/ports/Mk/bsd.port.mk" line 5796: Malformed conditional (${UID} != 0 && defined(_${:Ubuild:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER)) make: "/usr/ports/Mk/bsd.port.mk" line 5796: Malformed conditional (${UID} != 0 && defined(_${:Ustage:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER)) make: "/usr/ports/Mk/bsd.port.mk" line 5796: Malformed conditional (${UID} != 0 && defined(_${:Uinstall:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER)) make: "/usr/ports/Mk/bsd.port.mk" line 5796: Malformed conditional (${UID} != 0 && defined(_${:Utest:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER)) make: "/usr/ports/Mk/bsd.port.mk" line 5796: Malformed conditional (${UID} != 0 && defined(_${:Upackage:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER)) make: Fatal errors encountered -- cannot continue During make, so that seems to be required, or is this caused by something else ?
removed PORTREVISION removed ".include <bsd.port.pre.mk>" removed ".include <bsd.port.post.mk>" added ".include <bsd.port.mk>" instead portlint: WARN: Makefile: COMMENT should begin with a capital, and end without a period 0 fatal errors and 1 warning found. poudriere: Preparing installation to run
Created attachment 162926 [details] net/asterisk-chan_sccp directory Updated version -Based on v4.2.1 (includes fixes which previously required port-local patches) -removed PORTREVISION -removed ".include <bsd.port.pre.mk>" -removed ".include <bsd.port.post.mk>" -added ".include <bsd.port.mk>" instead
Created attachment 162941 [details] poudriere log for asterisk-chan_sccp Ran poudriere (FreeBSD-10.2) Successfully
Thank you Diederik
(In reply to Kubilay Kocak from comment #7) No problem :-)
(In reply to Kubilay Kocak from comment #7) Is there still anything i should do, to get this new port committed ? Did i overlook something ?
(In reply to Diederik de Groot from comment #9) Everything is perfectly fine here Diederik, there's nothing else you need to do. A committer needs to come along to 'take' the issue to resolution. Sometimes new ports can take a bit longer than their 'update' counterparts
(In reply to Kubilay Kocak from comment #10) Ok thanks. I wasn't sure if there was anything holding this up. I'll try to be patient :-)
Testbuilds @work
A commit references this bug: Author: pi Date: Sun Dec 13 13:17:48 UTC 2015 New revision: 403665 URL: https://svnweb.freebsd.org/changeset/ports/403665 Log: New port: net/asterisk-chan_sccp Replacement for the SCCP channel driver in Asterisk. Extended features include: - Shared Lines, - Presence / BLF, - Customizable Feature Buttons, - Custom Device State. - Conference with Phone-UI WWW: https://sourceforge.net/projects/chan-sccp-b PR: 204346 Submitted by: Diederik de Groot <ddegroot@talon.nl> Changes: head/net/Makefile head/net/asterisk-chan_sccp/ head/net/asterisk-chan_sccp/Makefile head/net/asterisk-chan_sccp/distinfo head/net/asterisk-chan_sccp/pkg-descr
Testbuilds are fine, committed, thanks!