Bug 204563 - [UPDATE] print/qpdfview to 0.4.16
Summary: [UPDATE] print/qpdfview to 0.4.16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Duchateau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-15 16:24 UTC by Olivier Duchateau
Modified: 2015-11-23 17:44 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (vg)

Attachments
Patch to update print/qpdfview (3.09 KB, patch)
2015-11-15 16:24 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau freebsd_committer freebsd_triage 2015-11-15 16:24:24 UTC 
Created attachment 163145 [details]
Patch to update print/qpdfview

- Update to 0.4.16
- Add support of Qt4 (set by default) and Qt5

Note: PDF option is removed, poppler-qt* is mandatory (depends of Qt release).
Comment 1 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-11-18 11:32:03 UTC 
Approved, you can commit it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-11-19 05:02:41 UTC 
A commit references this bug:

Author: olivierd
Date: Thu Nov 19 05:02:26 UTC 2015
New revision: 401914
URL: https://svnweb.freebsd.org/changeset/ports/401914

Log:
  - Update to 0.4.16
  - Add support of Qt4 (set by default) and Qt5

  PR:		204563
  Submitted by:	myself
  Approved by:	vg@ (maintainer)

Changes:
  head/print/qpdfview/Makefile
  head/print/qpdfview/distinfo
  head/print/qpdfview/pkg-plist
Comment 3 Olivier Duchateau freebsd_committer freebsd_triage 2015-11-19 05:04:11 UTC 
Committed.
Comment 4 Bengt Ahlgren 2015-11-22 16:21:48 UTC 
The port does unfortunately not build after the update.  See logs at:

http://portsmon.freebsd.org/portoverview.py?category=print&portname=qpdfview

There are some missing dependencies for the tools moc-qt4 and rcc.  This works for me:

--- print/qpdfview/Makefile.orig        2015-11-19 06:02:25.000000000 +0100
+++ print/qpdfview/Makefile     2015-11-22 16:18:26.860335146 +0100
@@ -33,7 +33,7 @@
 DJVU_LIB_DEPENDS=      libdjvulibre.so:${PORTSDIR}/graphics/djvulibre
 DJVU_QMAKE_OFF=        "CONFIG+=without_djvu"
 
-QT4_USE=       qt4=dbus,gui,linguisttools,sql,sql-sqlite3,svg,xml
+QT4_USE=       qt4=dbus,gui,linguisttools,sql,sql-sqlite3,svg,xml,moc,rcc
 QT4_LIB_DEPENDS=       libpoppler-qt4.so:${PORTSDIR}/graphics/poppler-qt4
 
 QT5_USE=       qt5=concurrent,linguisttools,printsupport,sql,sql-sqlite3

but is perhaps not the "correct" fix?  moc_build and rcc_build instead?
Comment 5 Bengt Ahlgren 2015-11-23 17:44:40 UTC 
(In reply to Bengt Ahlgren from comment #4)
Fixed independently by https://svnweb.freebsd.org/ports?view=revision&revision=402268