Bug 204632 - net-mgmt/p5-FusionInventory-Agent: Update to 2.3.17
Summary: net-mgmt/p5-FusionInventory-Agent: Update to 2.3.17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Veniamin Gvozdikov
URL: https://reviews.freebsd.org/D4133
Keywords: needs-qa, patch
: 197354 202480 203616 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-11-17 14:33 UTC by Mathieu Simon
Modified: 2016-02-04 15:34 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (vg)


Attachments
net-mgmt/p5-FusionInventory-Agent to 2.3.17 (61.19 KB, patch)
2015-12-21 07:04 UTC, Mathieu Simon
no flags Details | Diff
Update the FusionInventory Agent to 2.3.17 (63.09 KB, patch)
2016-02-02 12:40 UTC, Mathieu Simon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Simon 2015-11-17 14:33:59 UTC
Hi Veniamin

As I wrote you, I am likely there, that is the pretty updated version of 
your port. The review can be found here: https://reviews.freebsd.org/D4133

I've tried enabling everything that I could get working, including tests. The ordering of dependencies was done so it's easier to update in the future since upstream has an alphabetically ordered lists of dependencies in its Makefile.PL

Let me know what you think about.

-- Mathieu
Comment 1 Mathieu Simon 2015-11-17 14:44:27 UTC
Sidenote: I've notified the maintainer of p5-FusionInventory-Task-NetInventory about the review I posted since it will conflict with his port since his part has been integrated into the main agent.

Since both p5-FusionInventory-Task-NetInventory as well as -Task-SNMPQuery would be superseded, they should be expired if this main agent is updated.

-- Mathieu
Comment 2 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-12-07 09:39:12 UTC
*** Bug 197354 has been marked as a duplicate of this bug. ***
Comment 3 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-12-07 09:39:46 UTC
*** Bug 203616 has been marked as a duplicate of this bug. ***
Comment 4 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-12-07 09:40:00 UTC
*** Bug 202480 has been marked as a duplicate of this bug. ***
Comment 5 Mathieu Simon 2015-12-21 07:03:19 UTC
Hi Veniamin

I eventually forgot to upload the diff in here - excuse. If you find the time to look at it I'm happy to fix things in it. I haven't received other feedback on reviews.freebsd.org but forgot a bit about it, so here it is.

Let me know what needs to be done to have this patch landing in the ports tree :-)


Cheers,
Mathieu
Comment 6 Mathieu Simon 2015-12-21 07:04:08 UTC
Created attachment 164446 [details]
net-mgmt/p5-FusionInventory-Agent to 2.3.17
Comment 7 Mathieu Simon 2016-01-18 07:55:47 UTC
Hi

Any news on this? Objections, blockers? :-)

-- Mathieu
Comment 8 Mathieu Simon 2016-02-02 12:40:07 UTC
Created attachment 166433 [details]
Update the FusionInventory Agent to 2.3.17

The difference from the previous patch is that I've stumbled about a small-ish documentation bug that  --pidfile is not documented in the help output and the behaviour is a bit strange (if not given the pid file is simply empty).

Guillaume, the new upstream maintainer and I discussed that during FOSDEM quickly this makes the daemon start and stop properly under FreeBSD.

It would be great if you tell me about remaining blockers so the ports tree can finally get that quite (much) newer version.

-- Mathieu
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-02-04 15:30:08 UTC
A commit references this bug:

Author: vg
Date: Thu Feb  4 15:29:25 UTC 2016
New revision: 408042
URL: https://svnweb.freebsd.org/changeset/ports/408042

Log:
  - Upgrade to 2.3.17

  PR:		ports/204632
  Submitted by:	Mathieu Simon <freebsd@simweb.ch>

Changes:
  head/net-mgmt/p5-FusionInventory-Agent/Makefile
  head/net-mgmt/p5-FusionInventory-Agent/distinfo
  head/net-mgmt/p5-FusionInventory-Agent/files/fusioninventory.in
  head/net-mgmt/p5-FusionInventory-Agent/files/patch-Makefile.PL
  head/net-mgmt/p5-FusionInventory-Agent/files/patch-add_jails_support
  head/net-mgmt/p5-FusionInventory-Agent/files/patch-fix_install_paths
  head/net-mgmt/p5-FusionInventory-Agent/files/patch-more_raid_support
  head/net-mgmt/p5-FusionInventory-Agent/pkg-descr
  head/net-mgmt/p5-FusionInventory-Agent/pkg-plist
Comment 10 Veniamin Gvozdikov freebsd_committer freebsd_triage 2016-02-04 15:34:08 UTC
Committed, thank you!