Bug 204777 - [maintainer update][patch] www/rssroll: update to 0.5
Summary: [maintainer update][patch] www/rssroll: update to 0.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-11-24 11:18 UTC by Nikola Kolev
Modified: 2016-01-16 17:22 UTC (History)
0 users

See Also:

Attachments
rssroll 0.5 patch (2.47 KB, text/plain)
2015-11-24 11:18 UTC, Nikola Kolev 		no flags Details
new rssroll 0.5 patch (2.46 KB, patch)
2015-12-03 13:35 UTC, Nikola Kolev 		no flags Details | Diff
rssroll 0.5 patch fixed pkg-plist removed www ownership (2.46 KB, patch)
2015-12-23 11:09 UTC, Nikola Kolev 		no flags Details | Diff
rssroll 0.5 patch fixed pkg-plist; removed www ownership; remove PLIST_SUB; (2.48 KB, patch)
2016-01-08 09:49 UTC, Nikola Kolev 		koue: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2015-11-26 16:15:59 UTC 
Take.
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2015-12-01 05:58:24 UTC 
Hi,

I don't think there's any need for all those files to be owned by www:www.
WWWOWN is a user it can't be part of a path. Also, this should install itself into WWWDIR, not www directly.

Can you please rework this patch?
Comment 3 Nikola Kolev 2015-12-03 13:35:03 UTC 
Created attachment 163812 [details]
new rssroll 0.5 patch

New patch with fixed pkg-plist.
Files are still owned by WWW user. I think its better if web files are not owned by root.

http://rein.chaosophia.net/poudriere/rssroll-0.5-102x386.log.txt
http://rein.chaosophia.net/poudriere/rssroll-0.5-102x64.log.txt
http://rein.chaosophia.net/poudriere/rssroll-0.5-93x386.log.txt
http://rein.chaosophia.net/poudriere/rssroll-0.5-93x64.log.txt
Comment 4 Baptiste Daroussin freebsd_committer freebsd_triage 2015-12-15 10:04:54 UTC 
It is better if files are not owned by www users as the app will be run as www user. If the app gets rooted then you will be happy that the www user is not allowed to overwrite the files.

Only the files supposed to be accessed (write mode) by the application when running should be owned by the www user like cache files, temp files etc. all other files should not be owned by www user.
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2015-12-21 17:08:15 UTC 
back to pool
Comment 6 Nikola Kolev 2015-12-23 11:09:36 UTC 
Created attachment 164540 [details]
rssroll 0.5 patch fixed pkg-plist removed www ownership

Update previous patch by removing www user ownership of the files.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-07 08:51:47 UTC 
Can't be In Progress without an Assignee.

@Martin, Nikola has provided an updated patch. If you can't take care of this issue, please reset to 'Open'

@Nikola

 * Please confirm this updated change passes QA (portlint, poudriere)
 * Please set maintainer-approval to "+" on attachments for ports you are MAINTAINER of to ensure they get seen.
Comment 8 Martin Wilke freebsd_committer freebsd_triage 2016-01-07 09:05:11 UTC 
(In reply to Kubilay Kocak from comment #7)
thanks ;) I'll take care of it.
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-01-16 17:22:07 UTC 
A commit references this bug:

Author: miwi
Date: Sat Jan 16 17:21:18 UTC 2016
New revision: 406245
URL: https://svnweb.freebsd.org/changeset/ports/406245

Log:
  - Update to 0.5

  PR:		204777
  Submitted by:	maintainer

Changes:
  head/www/rssroll/Makefile
  head/www/rssroll/distinfo
  head/www/rssroll/pkg-plist