Bug 205017 - [PATCH] security/fastd: Disable mpclmul module on FreeBSD 9.
Summary: [PATCH] security/fastd: Disable mpclmul module on FreeBSD 9.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-12-04 14:31 UTC by Raphael Kubo da Costa
Modified: 2015-12-04 15:27 UTC (History)
2 users (show)

See Also:
crest: maintainer-feedback+

Attachments
Proposed patch (479 bytes, patch)
2015-12-04 14:31 UTC, Raphael Kubo da Costa 		no flags Details | Diff
Patch v2 (480 bytes, patch)
2015-12-04 15:10 UTC, Raphael Kubo da Costa 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 14:31:45 UTC 
Created attachment 163842 [details]
Proposed patch

The attached patch makes the port build on FreeBSD 9, which has failed ever since it was added to the tree.

From the fallout logs:
  CMake Error at src/crypto/mac/ghash/pclmulqdq/CMakeLists.txt:9 (message):
    WITH_MAC_GHASH_PCLMULQDQ enabled, but there is no compiler support for
    -mpclmul

This happens because GCC 4.2.1 in base (the default compiler) does not support the -mpcmul option.

Fix it by disabling the module when on FreeBSD < 10 (i.e. when base GCC is the default compiler).
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 15:10:23 UTC 
Created attachment 163845 [details]
Patch v2

Patch v2, with CMAKE_ARGS+= instead of CMAKE_ARGS=.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 15:27:32 UTC 
For some reason my commit was only mentioned in bug 205018. This was landed in https://svnweb.freebsd.org/changeset/ports/402993