Bug 205018 - [PATCH] security/fastd-devel: Disable mpclmul module on FreeBSD 9.
Summary: [PATCH] security/fastd-devel: Disable mpclmul module on FreeBSD 9.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-12-04 14:34 UTC by Raphael Kubo da Costa
Modified: 2015-12-04 15:24 UTC (History)
2 users (show)

See Also:
crest: maintainer-feedback+

Attachments
Proposed patch (523 bytes, patch)
2015-12-04 14:34 UTC, Raphael Kubo da Costa 		no flags Details | Diff
Patch v2 (524 bytes, patch)
2015-12-04 15:08 UTC, Raphael Kubo da Costa 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 14:34:20 UTC 
Created attachment 163843 [details]
Proposed patch

The attached patch makes the port build on FreeBSD 9, which has failed ever since it was added to the tree.

From the fallout logs:
  CMake Error at src/crypto/mac/ghash/pclmulqdq/CMakeLists.txt:9 (message):
    WITH_MAC_GHASH_PCLMULQDQ enabled, but there is no compiler support for
    -mpclmul

This happens because GCC 4.2.1 in base (the default compiler) does not support the -mpcmul option.

Fix it by disabling the module when on FreeBSD < 10 (i.e. when base GCC is the default compiler).
Comment 1 Jan Bramkamp 2015-12-04 14:39:01 UTC 
Please use += instead of = to concatenate the cmake arguments.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 15:08:51 UTC 
Created attachment 163844 [details]
Patch v2

Argh, stupid bsd.pre.port.mk. Patch v2 attached.
Comment 3 Jan Bramkamp 2015-12-04 15:16:19 UTC 
The non-devel version needs the same patch as well.
Comment 4 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 15:17:32 UTC 
Yeah, I updated it when I fixed this one.
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 15:18:09 UTC 
(in bug 205017)
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-12-04 15:22:44 UTC 
A commit references this bug:

Author: rakuco
Date: Fri Dec  4 15:22:35 UTC 2015
New revision: 402993
URL: https://svnweb.freebsd.org/changeset/ports/402993

Log:
  fastd, fastd-devel: Disable mpclmul module on FreeBSD 9.

  This fixes the build on 9, which has failed ever since it was added to the
  tree.

  From the fallout logs:
    CMake Error at src/crypto/mac/ghash/pclmulqdq/CMakeLists.txt:9 (message):
      WITH_MAC_GHASH_PCLMULQDQ enabled, but there is no compiler support for
      -mpclmul

  This happens because GCC 4.2.1 in base (the default compiler) does not
  support the -mpcmul option.

  Fix it by disabling the module when on FreeBSD < 10 (i.e. when base GCC is
  the default compiler).

  PR		205017
  PR:		205018
  Approved by:	Jan Bramkamp <crest_maintainer@rlwinm.de> (maintainer)

Changes:
  head/security/fastd/Makefile
  head/security/fastd-devel/Makefile