Bug 205022 - [PATCH] benchmarks/fio: Depend on flex and bison from ports on 9
Summary: [PATCH] benchmarks/fio: Depend on flex and bison from ports on 9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-12-04 17:59 UTC by Raphael Kubo da Costa
Modified: 2015-12-05 01:09 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)


Attachments
Proposed patch (692 bytes, patch)
2015-12-04 17:59 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 17:59:33 UTC
Created attachment 163849 [details]
Proposed patch

According to portsmon, benchmarks/fio's build is currently broken on 9 after the update to 2.2.11:

  lex: can't open lex.yy.c

with a verbose build it's possible to see that this is because base's flex on 9 is too old and does not support "-o foo", it requires "-ofoo".

Depending on flex from ports to fix the build is not enough, as then the yacc call fails:

  /usr/bin/yacc -o y.tab.c -l -d -b y exp/expression-parser.y
  yacc: e - line 68 of "exp/expression-parser.y", syntax error
  %parse-param { long long *result }
  ^
  Makefile:312: recipe for target 'y.tab.c' failed

Fix it by depending on both textproc/flex and devel/bison when the versions in base are too old.
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2015-12-04 19:54:58 UTC
Approved, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-05 01:09:24 UTC
A commit references this bug:

Author: rakuco
Date: Sat Dec  5 01:08:22 UTC 2015
New revision: 403016
URL: https://svnweb.freebsd.org/changeset/ports/403016

Log:
  Depend on flex and bison from ports on 9.

  According to portsmon, benchmarks/fio's build is currently broken on 9 after
  the update to 2.2.11:

    lex: can't open lex.yy.c

  with a verbose build it's possible to see that this is because base's flex
  on 9 is too old and does not support "-o foo", it requires "-ofoo".

  Depending on flex from ports to fix the build is not enough, as then the
  yacc call fails:

    /usr/bin/yacc -o y.tab.c -l -d -b y exp/expression-parser.y
    yacc: e - line 68 of "exp/expression-parser.y", syntax error
    %parse-param { long long *result }
    ^
    Makefile:312: recipe for target 'y.tab.c' failed

  Fix it by depending on both textproc/flex and devel/bison when the versions
  in base are too old.

  PR:		205022
  Approved by:	bapt (maintainer)

Changes:
  head/benchmarks/fio/Makefile