Created attachment 164143 [details] patch Remove a few non supported plugins, small grammar fixes.
http://www.cnet.com/news/end-of-the-line-for-aol-instant-messenger/ AIM is "Unofficially removed" so we decided to remove it as well. the AIM plugin uses these functions: toc_add_input_stream() toc_remove_input_stream() toc_main_interface() toc_timer() Toc has long been dead in favor of a harder to reverse engineer oscar https://en.wikipedia.org/wiki/OSCAR_protocol However the current AIM plugin uses TOC and we have no plans on updating it to use OSCAR. the commit that removed said plugin: use the git commit hisroty and view: 35b1a6 http://sourceforge.net/p/bitchx/git/commit_browser
Thanks. Could you please attach the patch in unified diff format?
svn diff defaults to unified
0a1,6 > This is an important > notice! It should > therefore be located at > the beginning of this > document! > 8,14c14 < compress the size of the < changes. < < This paragraph contains < text that is outdated. < It will be deleted in the < near future. This is what I call "diff output" *** /path/to/original ''timestamp'' --- /path/to/new ''timestamp'' *************** *** 1,3 **** --- 1,9 ---- + This is an important + notice! It should + therefore be located at + the beginning of this + document! + This part of the document has stayed the same from version to *************** *** 5,20 **** be shown if it doesn't change. Otherwise, that would not be helping to ! compress the size of the ! changes. ! ! This paragraph contains ! text that is outdated. ! It will be deleted in the Context output --- /path/to/original ''timestamp'' +++ /path/to/new ''timestamp'' @@ -1,3 +1,9 @@ +This is an important +notice! It should +therefore be located at +the beginning of this +document! + This part of the document has stayed the same from version to @@ -5,16 +11,10 @@ be shown if it doesn't change. Otherwise, that would not be helping to -compress the size of the -changes. - And unified.
Indeed, it's just that those headers looked extraneous. My apologies. Also, why did you revert the subject (breaking the port name in the process)? A precise summary helps speed up resolution.
simply put I like my subject. longer version I don't see how adding too much crap on a subject helps. the time it has taken you to moan about my patch not being unified you could of: 1. applied patch 2. tested patch using poudie how ever the hell you spell it 3. commited.
(In reply to BitchX FreeBSD from comment #6) I'm not a committer. I'm volunteering my time as part of the new, experimental bug triage team. We categorize problem reports and ensure they're precise and containing as much info as possible. So "moaning" about unified diffs and imprecise summaries, is part of that task. ;) Please mark your patch maintainer-approved, if you approve it, since you're the maintainer.
More like over complicating a simple task
A commit references this bug: Author: junovitch Date: Fri Dec 18 01:57:03 UTC 2015 New revision: 403948 URL: https://svnweb.freebsd.org/changeset/ports/403948 Log: irc/bitchx: drop AIM plugin support and grammar fixes - Remove AIM plugin support as it is no longer supported - Bump PORTREVISION for package change - While here, minor grammar changes in pkg-descr and Makefile PR: 205260 Submitted by: cpet@bitchx.org (maintainer) Changes: head/irc/bitchx/Makefile head/irc/bitchx/pkg-descr head/irc/bitchx/pkg-plist
Committed with changes. However... @Vladimir, the Porter's Handbook clearly states "When possible, please submit a svn(1) diff." [1]. Please refrain from requesting unnecessary changes against the Handbook. [1] https://www.FreeBSD.org/doc/en_US.ISO8859-1/books/porters-handbook/port-upgrading.html#svn-diff @freebsd@bitchx.org, Several of the pkg-descr grammar updates were left as is. Avoiding contractions and the use of double space is standard FreeBSD policy [2]. [2] https://www.FreeBSD.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-guidelines.html @all, My apology, I accidentally attributed the email in comment 2 in the commit logs instead of the submitter (cpet@bitchx.org instead of freebsd@bitchx.org). For the PR history freebsd@bitchx.org is the submitter/maintainer.