Bug 205271 - comms/fldigi switch to USES=execinfo, use options helpers
Summary: comms/fldigi switch to USES=execinfo, use options helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-12-12 17:06 UTC by Pawel Pekala
Modified: 2015-12-16 02:46 UTC (History)
2 users (show)

See Also:
pawel: maintainer-feedback+

Attachments
fldigi modernize patch (1.64 KB, patch)
2015-12-12 17:06 UTC, Pawel Pekala 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2015-12-12 17:06:34 UTC 
Created attachment 164151 [details]
fldigi modernize patch

Small update of port to current standards:

- Remove pkg-config dependency from BUILD_DEPENDS, it's implied by USES=pkgconfig
- Switch to USES=execinfo, this will use external libexecinfo only when needed
- Use options helpers
- Remove usage of deprecated MAN1 variable, pkg-plist is handling this anyway
Comment 1 Stephen Hurd freebsd_committer freebsd_triage 2015-12-15 07:53:19 UTC 
Looks good to me, feel free to commit if you've done test builds.  If not, I can test and commit tomorrow.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-15 19:58:36 UTC 
A commit references this bug:

Author: pawel
Date: Tue Dec 15 19:58:17 UTC 2015
New revision: 403801
URL: https://svnweb.freebsd.org/changeset/ports/403801

Log:
  - Remove pkg-config dependency from BUILD_DEPENDS, it's
    implied by USES=pkgconfig
  - Switch to USES=execinfo, this will use external libexecinfo
    from ports only when needed
  - Use options helpers
  - Remove usage of deprecated MAN1 variable, pkg-plist is handling this anyway

  PR:		205271
  Submitted by:	me
  Approved by:	shurd

Changes:
  head/comms/fldigi/Makefile
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2015-12-15 20:00:55 UTC 
I always do test builds before submitting patches, thanks.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-16 02:46:42 UTC 
Assign to committer that resolved