Bug 205430 - net/minidlna: Server not visible in network since 1.1.5 update
Summary: net/minidlna: Server not visible in network since 1.1.5 update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Guido Falsi
URL: http://lists.freebsd.org/pipermail/fr...
Keywords: needs-qa, regression
Depends on:
Blocks:
 
Reported: 2015-12-19 11:21 UTC by pvoigt
Modified: 2016-01-16 10:21 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (wg)
madpilot: merge-quarterly+


Attachments
Test patch (1.15 KB, patch)
2016-01-01 21:34 UTC, Guido Falsi
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pvoigt 2015-12-19 11:21:28 UTC
Yesterday I have upgraded net/minidlna to the latest version. I am on FreeBSD
10.2-RELEASE-p8 (amd64).

Access via web interface on port 8200 is working fine showing the correct number of media files.

But the MiniDLNA server is not seen in my network and correspondingly I cannot access any of my FLAC audio files. I do not host any other media besides the
FLAC files.

I have confirmed downgrading to the previous version (r397778) solves the issue.

The issue is discussed on the list as well:
http://lists.freebsd.org/pipermail/freebsd-ports/2015-December/101422.html
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-19 11:28:51 UTC
CC last committer as well
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2015-12-19 12:41:14 UTC
Sorry my update is causing problems.

I have been using 1.1.5 for a almost a month on my home server and it's been working fine.

There's just one thing that comes to my mind, what's the value of the notify_interval configuration on your server? Maybe lowering this would fix your problem.

I'll check if there's any other change which could be causing this.
Comment 3 pvoigt 2015-12-31 08:56:29 UTC
Sorry, did not read your suggestion on the notify intervall. I am using notify_interval=900 since version 1.1.3. I did not yet find time to check with lower values. Is there something wrong with my current setting?
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2016-01-01 21:34:05 UTC
Created attachment 164940 [details]
Test patch

Nothing wrong with your interval, simply, lowering it you cause the server to announce itself more often, so setting it to a low value(60 or 30) could be a workaround for the problem you're seeing.

In the while I have found a change in this release which could be the cause of your problem.

Could you test the attached patch and report back?

Thanks!
Comment 5 pvoigt 2016-01-03 13:32:02 UTC
I have just returned from a short vacation. Unfortunately, I have not been informed by email about your latest comment regarding your supplied patch, although I have added my email address to the "CC list". I suppose the missing email notification might be related to Bug 205431.

Nevertheless, I have just applied and tested your patch and now net/minidlna 1.1.5 works as expected, e.g. it is visible in my network again.

Thanks for fixing this issue.
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2016-01-04 19:01:19 UTC
Thanks to the OP for testing and reporting back.

wg, can you take a look at this patch and see if you can approve it?

This issue should also be reported upstream, are you going to do it?

If you're busy I can file a bug report upstream myself.

Thanks in advance.
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2016-01-05 17:19:38 UTC
Forgot to mention, I think this one needs to be merged to the quarterly branch too.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-15 17:24:29 UTC
Comment on attachment 164940 [details]
Test patch

@Guido, William is currently on holiday and has approved commits to his ports. 

Once you're happy with the QA for this change (user confirmation, poudriere, etc), feel free to assign yourself to resolve (Adding wg@ to CC to keep him in the loop)
Comment 9 everytrash 2016-01-15 18:28:12 UTC
(In reply to Guido Falsi from comment #7)

Yes please! I have upgraded today to the latest version and have the same error.
Comment 10 Guido Falsi freebsd_committer freebsd_triage 2016-01-15 19:47:34 UTC
Take bug due to wg being away.

Performing a few last checks before committing.
Comment 11 commit-hook freebsd_committer freebsd_triage 2016-01-15 22:38:44 UTC
A commit references this bug:

Author: madpilot
Date: Fri Jan 15 22:38:36 UTC 2016
New revision: 406193
URL: https://svnweb.freebsd.org/changeset/ports/406193

Log:
  Revert upstream change which prevents minidlna from replying to
  certain multicast queries.

  PR:		205430
  Submitted by:	pvoigt@uos.de
  Approved by:	wg (maintainer, implicit)
  MFH:		2016Q1

Changes:
  head/net/minidlna/Makefile
  head/net/minidlna/files/patch-minissdp.c
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-01-16 10:19:29 UTC
A commit references this bug:

Author: madpilot
Date: Sat Jan 16 10:19:22 UTC 2016
New revision: 406207
URL: https://svnweb.freebsd.org/changeset/ports/406207

Log:
  MFH: r406193

  Revert upstream change which prevents minidlna from replying to
  certain multicast queries.

  PR:		205430
  Submitted by:	pvoigt@uos.de
  Approved by:	wg (maintainer, implicit)

  Approved by:	portmgr (erwin)

Changes:
_U  branches/2016Q1/
  branches/2016Q1/net/minidlna/Makefile
  branches/2016Q1/net/minidlna/files/patch-minissdp.c
Comment 13 Guido Falsi freebsd_committer freebsd_triage 2016-01-16 10:21:29 UTC
Committed Thanks!