Bug 205716 - sysutils/logrotate: Update to 3.9.2
Summary: sysutils/logrotate: Update to 3.9.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL: https://github.com/logrotate/logrotat...
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-12-30 07:11 UTC by Douglas Thrift
Modified: 2016-01-30 07:01 UTC (History)
2 users (show)

See Also:
js: maintainer-feedback+

Attachments
sysutils/logrotate-3.8.9_2.diff (882 bytes, patch)
2015-12-30 07:11 UTC, Douglas Thrift 		no flags Details | Diff
sysutils/logrotate-3.9.2.diff (1.22 KB, patch)
2016-01-26 06:17 UTC, Douglas Thrift 		js: maintainer-approval+
Details | Diff
logs/logrotate-3.9.2.log (20.87 KB, text/plain)
2016-01-26 06:18 UTC, Douglas Thrift 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Thrift 2015-12-30 07:11:00 UTC 
Created attachment 164845 [details]
sysutils/logrotate-3.8.9_2.diff

I have added a patch that fixes sysutils/logrotate so that subdirectory globs such as /var/log/httpd/*/*.log work correctly. I have also submitted the patch upstream:

https://github.com/logrotate/logrotate/pull/13
Comment 1 js 2015-12-30 19:08:15 UTC 
I like it. Unfortunately I can't test it right now, but the patch itself is clean and straightforward. I hope the original patch finds its way to he app too. We should upgrade for that release then :)
Comment 2 js 2015-12-30 19:09:00 UTC 
Also, thanks for the github link.
Comment 3 js 2016-01-25 07:12:20 UTC 
Logrotate 3.9.2 has been released, and if I'm not mistaken, it contains this patch. Just saying.
Comment 4 Douglas Thrift 2016-01-26 06:17:00 UTC 
Created attachment 166132 [details]
sysutils/logrotate-3.9.2.diff

I've updated it to 3.9.2.

"portlint -C" reports "looks fine."
I will attach the "poudriere testport" log.
Comment 5 Douglas Thrift 2016-01-26 06:18:13 UTC 
Created attachment 166133 [details]
logs/logrotate-3.9.2.log

Here is the poudriere testport log.
Comment 6 js 2016-01-26 06:31:12 UTC 
Exactly. I approve this change. Unfortunately I can't add two maint feedback+es.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-26 14:57:15 UTC 
Comment on attachment 166132 [details]
sysutils/logrotate-3.9.2.diff

Please set maintainer-approval to + if you approve, or - to decline
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-26 14:58:05 UTC 
@Douglas, if you could update the summary of any issues if/as their scope changes, that would be great :)
Comment 9 js 2016-01-26 22:33:05 UTC 
Comment on attachment 166132 [details]
sysutils/logrotate-3.9.2.diff

I couldn't do it better myself.
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-01-30 07:01:05 UTC 
A commit references this bug:

Author: pi
Date: Sat Jan 30 07:00:11 UTC 2016
New revision: 407515
URL: https://svnweb.freebsd.org/changeset/ports/407515

Log:
  sysutils/logrotate: 3.8.9 -> 3.9.2

  Changes:
  - Upstream moved to GitHub: https://github.com/logrotate/logrotate.
  - Add support for %M, %S and %V in "dateext" directive.
  - Fix bad filename in subject of email when "compress" and "maillast" is used.
  - Allow rotating files created before 1996.
  - Fix compilation errors on NetBSD caused by "array subscript has
    type 'char' in config.c".
  - Fix matching subdirectories on BSD systems for patterns like
    "*/log" in situation where logrotate tried to match "foo/log" even
    when "foo" has not been a directory.
  - Fix logging dates in debug messages.
  - Remove state file entries for logs which do not exist and have
    not been rotated for more than a year.
  - Fix poor performance with big state file.
  - Support logging to syslog by using '-l syslog'.
  - Allow running test-suite using dash.

  PR:		205716
  Submitted by:	douglas@douglasthrift.net
  Approved by:	js@iksz.hu (maintainer)

Changes:
  head/sysutils/logrotate/Makefile
  head/sysutils/logrotate/distinfo
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2016-01-30 07:01:54 UTC 
Testbuilds all fine, committed,thanks!