Bug 205817 - [PATCH] update sysutils/pefs-kmod to support D3929 (r292782)
Summary: [PATCH] update sysutils/pefs-kmod to support D3929 (r292782)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Kurtsou
URL:
Keywords: needs-qa, patch, regression
Depends on:
Blocks:
 
Reported: 2016-01-03 05:43 UTC by Eric Camachat
Modified: 2016-03-14 17:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gleb)
koobs: merge-quarterly?

Attachments
Replace sha2.{c,h} by sha512{c.c,.h}. (19.38 KB, patch)
2016-01-03 05:43 UTC, Eric Camachat 		no flags Details | Diff
Fix on newer FreeBSD (20.06 KB, patch)
2016-02-28 05:23 UTC, Eric Camachat 		no flags Details | Diff
Update port to 2016-02-18 version (815 bytes, patch)
2016-02-29 21:22 UTC, Gleb Kurtsou 		no flags Details | Diff
updated diff file (22.12 KB, patch)
2016-03-01 17:50 UTC, Eric Camachat 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Camachat 2016-01-03 05:43:19 UTC 
Created attachment 164980 [details]
Replace sha2.{c,h} by sha512{c.c,.h}.

After D3929 (r292782), "kldload pefs" will complain "SHA512_Init undefined".
The comments in r292782 mentioned all sha2.{c,h} should be replaced by sha512{c.c,.h}, and here is the patch that does it.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-03 12:15:35 UTC 
Do any of these changes (patches) need to be conditional on OSVERSION, or have all of the relevant commits referenced (r292782 [1], r263218 [2]) been MFC'd to all stable (9,10) branches?

[1] https://svnweb.freebsd.org/base?view=revision&revision=292782
[2] https://svnweb.freebsd.org/base?view=revision&revision=263218
Comment 2 Gleb Kurtsou freebsd_committer freebsd_triage 2016-01-24 19:08:09 UTC 
FYI sendfile merge in r292373 broke mmap in pefs. I'm looking into it.
Comment 3 Eric Camachat 2016-02-28 05:23:29 UTC 
Created attachment 167496 [details]
Fix on newer FreeBSD

Fix on my r296151 11.0-CURRENT.
Comment 4 Gleb Kurtsou freebsd_committer freebsd_triage 2016-02-29 21:22:44 UTC 
Created attachment 167579 [details]
Update port to 2016-02-18 version

Workaround for vnode pager issue and build fix has been committed upstream at
https://github.com/glk/pefs


More info on vnode pager issue:
http://marc.info/?l=freebsd-commits-all&m=145549112823518&w=2

Patch to update the port attached. Eric could you please verify it works for you. I don't really see a difference between your two patches, so how does the later one fix the build? Could you elaborate.
Comment 5 Eric Camachat 2016-03-01 04:02:40 UTC 
You're right, it was a building issue.
Comment 6 Eric Camachat 2016-03-01 17:50:41 UTC 
Created attachment 167614 [details]
updated diff file

After some re-test, I found that I didn't `svn add` new files. So the new files were not included in previous patch.
Comment 7 Gleb Kurtsou freebsd_committer freebsd_triage 2016-03-02 04:24:19 UTC 
Regardless, does the updated version 2016-02-18 work for you? I intend to get it committed shortly.
Comment 8 Eric Camachat 2016-03-02 06:10:25 UTC 
2016-02-18 works for me.
Comment 9 Mikael Urankar freebsd_committer freebsd_triage 2016-03-02 08:35:50 UTC 
Gleb,
I'm also a pefs user and your patch works fine! Thanks a lot.
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-03-03 14:22:39 UTC 
A commit references this bug:

Author: sbruno
Date: Thu Mar  3 14:22:14 UTC 2016
New revision: 410041
URL: https://svnweb.freebsd.org/changeset/ports/410041

Log:
  Update port to 20016-02-18.

  PR:		205817
  Submitted by:	gleb

Changes:
  head/sysutils/pefs-kmod/Makefile
  head/sysutils/pefs-kmod/distinfo