Bug 205951 - net-im/pidgin: post-stage is broken
Summary: net-im/pidgin: post-stage is broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-06 10:27 UTC by Piotr Kubaj
Modified: 2016-01-06 15:38 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
remove post-stage (444 bytes, patch)
2016-01-06 10:27 UTC, Piotr Kubaj 		no flags Details | Diff
remove post-stage, remove .packlist from pkg-plist (854 bytes, patch)
2016-01-06 10:33 UTC, Piotr Kubaj 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2016-01-06 10:27:56 UTC 
Created attachment 165150 [details]
remove post-stage

Update to 2.10.12 broke the port. The build is broken in post-stage, during seding non-existent file (it seems it wasn't moved, it doesn't exist now). Removing post-stage from Makefile fixes the problem.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2016-01-06 10:32:51 UTC 
It also seems that post-stage is only broken when PERL=on. .packlist (the non-existent file) should be removed from pkg-plist. I've updated the patch to take care of that.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2016-01-06 10:33:32 UTC 
Created attachment 165151 [details]
remove post-stage, remove .packlist from pkg-plist
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2016-01-06 10:51:37 UTC 
I've verified that the file is actually there if you install with PERL=on, so I'm not sure why post-stage worked before. Anyway, changing post-stage to post-stage-PERL-on works with PERL ON or OFF.


Index: Makefile
===================================================================
--- Makefile	(revision 405316)
+++ Makefile	(working copy)
@@ -29,7 +29,7 @@
 		--enable-screensaver \
 		--with-dynamic_prpls=${PRPL_MODULES:S/,$//}
 
-post-stage:
+post-stage-PERL-on:
 	@${SED} -i '' -e 's|^${STAGEDIR}||g' \
 		${STAGEDIR}${PREFIX}/lib/pidgin/perl/auto/Pidgin/.packlist
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2016-01-06 10:52:34 UTC 
Comment on attachment 165151 [details]
remove post-stage, remove .packlist from pkg-plist

>Index: Makefile
>===================================================================
>--- Makefile	(revision 405316)
>+++ Makefile	(working copy)
>@@ -29,10 +29,6 @@
> 		--enable-screensaver \
> 		--with-dynamic_prpls=${PRPL_MODULES:S/,$//}
> 
>-post-stage:
>-	@${SED} -i '' -e 's|^${STAGEDIR}||g' \
>-		${STAGEDIR}${PREFIX}/lib/pidgin/perl/auto/Pidgin/.packlist
>-
> post-install:
> 	${INSTALL_MAN} ${WRKSRC}/doc/pidgin.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
> 
>Index: pkg-plist
>===================================================================
>--- pkg-plist	(revision 405316)
>+++ pkg-plist	(working copy)
>@@ -51,7 +51,6 @@
> include/pidgin/pidgintooltip.h
> %%PERL:%%lib/pidgin/perl/Pidgin.pm
> %%PERL:%%lib/pidgin/perl/auto/Pidgin/Pidgin.so
>-%%PERL:%%lib/pidgin/perl/auto/Pidgin/.packlist
> %%CAP%%lib/pidgin/cap.so
> lib/pidgin/convcolors.so
> lib/pidgin/extplacement.so
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-01-06 15:37:07 UTC 
A commit references this bug:

Author: marcus
Date: Wed Jan  6 15:36:45 UTC 2016
New revision: 405361
URL: https://svnweb.freebsd.org/changeset/ports/405361

Log:
  Use a better Perl fix.

  PR:		205951
  Submitted by:	 Piotr Kubaj

Changes:
  head/net-im/pidgin/Makefile
Comment 6 Joe Marcus Clarke freebsd_committer freebsd_triage 2016-01-06 15:38:15 UTC 
Should be fixed now.  Thanks!