Bug 206160 - games/wtf: Add LICENSE (Public Domain)
Summary: games/wtf: Add LICENSE (Public Domain)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-01-12 15:54 UTC by Nikolai Lifanov
Modified: 2016-01-12 20:09 UTC (History)
1 user (show)

See Also:

Attachments
games/wtf: add license (478 bytes, patch)
2016-01-12 15:54 UTC, Nikolai Lifanov 		lifanov: maintainer-approval+
Details | Diff
games/wtf: add license (no portrevision bump) (358 bytes, patch)
2016-01-12 16:32 UTC, Nikolai Lifanov 		lifanov: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolai Lifanov 2016-01-12 15:54:35 UTC 
Created attachment 165440 [details]
games/wtf: add license

After recent licenses database change, add PD
(explicitly specified by NetBSD for these files).
Comment 1 John Marino freebsd_committer freebsd_triage 2016-01-12 16:17:07 UTC 
I don't think we bump portrevision for license changes.
Comment 2 Nikolai Lifanov 2016-01-12 16:27:44 UTC 
Feel free to disagree, but license change results in a different package.

$ echo "SELECT licenses.name
>       FROM licenses,packages,pkg_licenses
>       WHERE packages.name like 'ansible%'
>       AND licenses.id=license_id
>       AND packages.id=package_id;" | pkg shell
GPLv3
Comment 3 John Marino freebsd_committer freebsd_triage 2016-01-12 16:30:06 UTC 
of course it does.

So does changed the pkg-descr or COMMENT.

There's a general policy that data changes like that do not mandate a new package being built.  Yes, that specifically applies to licenses too.   It's been discussed.

it's not the end of the world if it gets bumped, but generally you do NOT bump for the addition of a license (maybe maybe for a license change, but this is not a change)
Comment 4 Nikolai Lifanov 2016-01-12 16:32:03 UTC 
Good to know. I didn't realize this. I thought that package changes needed bumps.
Comment 5 Nikolai Lifanov 2016-01-12 16:32:31 UTC 
Created attachment 165443 [details]
games/wtf: add license (no portrevision bump)
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-01-12 20:09:12 UTC 
A commit references this bug:

Author: amdmi3
Date: Tue Jan 12 20:09:07 UTC 2016
New revision: 405909
URL: https://svnweb.freebsd.org/changeset/ports/405909

Log:
  - Add LICENSE

  PR:		206160
  Submitted by:	lifanov@mail.lifanov.com (maintainer)

Changes:
  head/games/wtf/Makefile