Description Dimitry Andric 2016-01-17 14:56:08 UTC

Created attachment 165718 [details]
Parenthesize journal_iter_is_removed macro so it doesn't cause warnings

During the exp-run in bug 206074, it was found that devel/dee gives errors with a recent clang 3.8.0 snapshot:

dee-transaction.c:1245:17: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses]
      g_assert (!journal_iter_is_removed (jiter));
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/glib-2.0/glib/gtestutils.h:106:59: note: expanded from macro 'g_assert'
                                             if G_LIKELY (expr) ; else \
                                                          ^~~~
/usr/local/include/glib-2.0/glib/gmacros.h:325:59: note: expanded from macro 'G_LIKELY'
#define G_LIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR(expr), 1))
                                                          ^~~~
/usr/local/include/glib-2.0/glib/gmacros.h:319:8: note: expanded from macro '_G_BOOLEAN_EXPR'
   if (expr)                                    \
       ^~~~
dee-transaction.c:1245:17: note: add parentheses after the '!' to evaluate the comparison first
dee-transaction.c:1245:17: note: add parentheses around left hand side expression to silence this warning
1 error generated.

This is because the journal_iter_is_removed() macro does not have parentheses around its expression.  Here is a patch to fix that.