Bug 206359 - www/serf: remove unecessary do-build / do-install
Summary: www/serf: remove unecessary do-build / do-install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lev A. Serebryakov
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-01-18 05:24 UTC by John Hein
Modified: 2016-09-06 13:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lev)
koobs: merge-quarterly?

Attachments
[patch] remove local do-* targets - defaults are fine (1014 bytes, patch)
2016-01-18 05:24 UTC, John Hein 		no flags Details | Diff
[patch] remove local do-* targets - defaults are fine [v2 after r406512 - see bug 206319] (1013 bytes, patch)
2016-01-18 14:00 UTC, John Hein 		no flags Details | Diff
[patch] v2 - don't replace stock do-build/do-install (651 bytes, patch)
2016-03-27 02:50 UTC, John Hein 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2016-01-18 05:24:58 UTC 
Created attachment 165743 [details]
[patch] remove local do-* targets - defaults are fine

The do-build & do-install in this port are unnecessary.

Patch attached.

QA
 - portlint - 1 warning (unrelated)
 - stage-qa - passed
 - poudriere testport - passed 10-stable/amd64
Comment 1 John Hein 2016-01-18 05:28:17 UTC 
Note: the patch also removed some redundant MAKE_ARGS (see Uses/scons.mk - why CFLAGS is not in the list of MAKE_ARGS variables in scons.mk, I don't know.  Otherwise CFLAGS could be removed here, too).
Comment 2 John Hein 2016-01-18 14:00:25 UTC 
Created attachment 165760 [details]
[patch] remove local do-* targets - defaults are fine [v2 after r406512 - see bug 206319]

Re-gen v2 of patch after r206319.  Apply original (now obsolete) patch if you don't have r206319 merged into your tree.
Comment 3 John Hein 2016-01-18 14:09:19 UTC 
Comment on attachment 165760 [details]
[patch] remove local do-* targets - defaults are fine [v2 after r406512 - see bug 206319]

Sorry - I meant r406512 (due to bug 206319), not r206319.
Comment 4 Lev A. Serebryakov freebsd_committer freebsd_triage 2016-03-19 14:10:25 UTC 
Removing SCONS_ARGS doesn't work for me:

===>  Building for serf-1.3.8_1
scons: Reading SConscript files ...
Unknown variables: CXX, PKGCONFIGDIR, destdir, LIBPATH, CXXFLAGS, CCFLAGS, CPPPATH, OPENSSL_CFLAGS
===> Compilation failed unexpectedly.
Comment 5 John Hein 2016-03-27 02:50:11 UTC 
Created attachment 168667 [details]
[patch] v2 - don't replace stock do-build/do-install

Lev, you're right - the serf sConstruct file catches extra args.  Here's an alternate patch.
Comment 6 Lev A. Serebryakov freebsd_committer freebsd_triage 2016-09-06 13:20:12 UTC 
Committed, thanx!
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-09-06 13:20:17 UTC 
A commit references this bug:

Author: lev
Date: Tue Sep  6 13:19:52 UTC 2016
New revision: 421423
URL: https://svnweb.freebsd.org/changeset/ports/421423

Log:
   Update to 1.3.9
   Simplify Makefile

  PR:		212345, 206359
  Submitted by:	Olli Hauer <ohauer@FreeBSD.org>, John Hein <z7dr6ut7gs@snkmail.com>

Changes:
  head/www/serf/Makefile
  head/www/serf/distinfo
  head/www/serf/files/patch-SConstruct