Bug 206568 - [maintainer update][patch] japanese/today: Fix line breaks conversion
Summary: [maintainer update][patch] japanese/today: Fix line breaks conversion
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Raphael Kubo da Costa
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-01-24 12:46 UTC by WATANABE Kazuhiro
Modified: 2016-02-28 23:50 UTC (History)
1 user (show)

See Also:


Attachments
A patch for japanese/today (637 bytes, patch)
2016-01-24 12:46 UTC, WATANABE Kazuhiro
no flags Details | Diff
poudriere testport log without my patch (10.1-RELEASE amd64) (136.78 KB, text/x-log)
2016-01-24 12:48 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log with my patch (10.1-RELEASE amd64) (136.57 KB, text/x-log)
2016-01-24 12:48 UTC, WATANABE Kazuhiro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2016-01-24 12:46:36 UTC
Created attachment 166054 [details]
A patch for japanese/today

Current japanese/today converts each file's line breaks from CRLF to LF
with the following procedure in Makefile:

 ${SED} 's/.$$//'

It is a very problematic method, and breaks many Japanese strings in
the data files (*.tbl).

To solve the problem, use "${TR} -d '\015'" for the conversion.
Comment 1 WATANABE Kazuhiro 2016-01-24 12:48:04 UTC
Created attachment 166055 [details]
poudriere testport log without my patch (10.1-RELEASE amd64)
Comment 2 WATANABE Kazuhiro 2016-01-24 12:48:43 UTC
Created attachment 166056 [details]
poudriere testport log with my patch (10.1-RELEASE amd64)
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-02-28 23:48:14 UTC
A commit references this bug:

Author: rakuco
Date: Sun Feb 28 23:47:38 UTC 2016
New revision: 409785
URL: https://svnweb.freebsd.org/changeset/ports/409785

Log:
  Fix line breaks conversion.

  Current japanese/today converts each file's line breaks from CRLF to LF
  with the following procedure in Makefile:

   ${SED} 's/.$$//'

  It is a very problematic method, and breaks many Japanese strings in
  the data files (*.tbl).

  To solve the problem, use "${TR} -d '\015'" for the conversion.

  PR:		206568
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp> (maintainer)

Changes:
  head/japanese/today/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-02-28 23:49:16 UTC
A commit references this bug:

Author: rakuco
Date: Sun Feb 28 23:48:45 UTC 2016
New revision: 409786
URL: https://svnweb.freebsd.org/changeset/ports/409786

Log:
  MFH: r409785

  Fix line breaks conversion.

  Current japanese/today converts each file's line breaks from CRLF to LF
  with the following procedure in Makefile:

   ${SED} 's/.$$//'

  It is a very problematic method, and breaks many Japanese strings in
  the data files (*.tbl).

  To solve the problem, use "${TR} -d '\015'" for the conversion.

  PR:		206568
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp> (maintainer)

  Approved by:	portmgr blanket approval

Changes:
_U  branches/2016Q1/
  branches/2016Q1/japanese/today/Makefile
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-02-28 23:50:17 UTC
Committed, thanks!