Bug 206589 - multimedia/openh264 not prefix-safe
Summary: multimedia/openh264 not prefix-safe
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2016-01-25 01:03 UTC by Mikhail Teterin
Modified: 2016-02-09 00:58 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2016-01-25 01:03:48 UTC 
Vendor's code needs to have PREFIX explicitly specified, otherwise /usr/local is assumed, which breaks staging on systems with a different prefix. The following patch fixes the problem:

Index: Makefile
===================================================================
--- Makefile    (revision 407188)
+++ Makefile    (working copy)
@@ -22,7 +22,7 @@
 ASFLAGS_arm64_clang=   -no-integrated-as
 MAKE_ARGS=     OS=bsd ARCH="${ARCH:S/amd64/x86_64/}" \
                CCASFLAGS='$$(CFLAGS) ${ASFLAGS}' \
-               CFLAGS_OPT="" CFLAGS_DEBUG=""
+               CFLAGS_OPT="" CFLAGS_DEBUG="" PREFIX="${PREFIX}"
 ALL_TARGET=    all
 
 OPTIONS_DEFINE=        DEBUG PLUGINS TEST
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-02-09 00:54:00 UTC 
A commit references this bug:

Author: jbeich
Date: Tue Feb  9 00:53:14 UTC 2016
New revision: 408520
URL: https://svnweb.freebsd.org/changeset/ports/408520

Log:
  multimedia/openh264: partially unbreak PREFIX != LOCALBASE

  PR:		206589
  Submitted by:	mi

Changes:
  head/multimedia/openh264/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-02-09 00:58:01 UTC 
A commit references this bug:

Author: jbeich
Date: Tue Feb  9 00:57:34 UTC 2016
New revision: 408521
URL: https://svnweb.freebsd.org/changeset/ports/408521

Log:
  MFH: r408520

  multimedia/openh264: partially unbreak PREFIX != LOCALBASE

  PR:		206589
  Submitted by:	mi
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2016Q1/
  branches/2016Q1/multimedia/openh264/Makefile