Created attachment 166781 [details] Add patches with fixes There was a GSoC 2015 from Colin Lord to bring to the base system a recent version of Ficl. It found many bugs in ficl4. Among them: - Fix ficlInstructionPick bug. Pick instructions from 0, not 1. Credit to Toomas Soome from the Illumos project. - Fix some math bugs. Credit to Toomas Soome from the Illumos project. - Fix bug in Ficl stack preventing the stack from growing. Obtained from: http://sourceforge.net/p/ficl/mailman/message/26634755/ - Change rand and srand calls to random and srandom Submitted by: pfg It would be nice to bring these fixes to the port. Pet portlint while here.
Comment on attachment 166781 [details] Add patches with fixes (Set as diff: for some reason attaching files from chromium is not working properly)
Created attachment 167296 [details] Patches from SoC 2015. Many thanks Pedro F. Giffuni. Hello. Thank you very much for your attention.
Created attachment 167297 [details] It's log of build this port.
Created attachment 167298 [details] portlint log file for this a port
(In reply to Pavel Volkov from comment #2) > Created attachment 167296 [details] > Patches from SoC 2015. Many thanks Pedro F. Giffuni. > > Hello. > Thank you very much for your attention. The patch doesn't look entirely right: it's at least creating a patch-ficl.h in the port's top-level directory.
(In reply to Raphael Kubo da Costa from comment #5) Yes, the problem seems to be only in the latest diff. My original patch doesn't have it: % svn status lang/ficl M lang/ficl/files/patch-dictionary.c A lang/ficl/files/patch-double.c M lang/ficl/files/patch-ficl.h M lang/ficl/files/patch-float.c M lang/ficl/files/patch-primitives.c M lang/ficl/files/patch-tools.c A lang/ficl/files/patch-vm.c M lang/ficl/pkg-descr
It'd be great if someone could submit a final version then. Pedro's original patch is almost complete, but doesn't change Makefile. Pavel's patch has an additional file that shouldn't be created, and I don't get the removal of the DOCS option (it's the DATA one that doesn't seem to have any effect). Additionally, it looks like MAKE_JOBS_UNSAFE=yes can be removed too.
Created attachment 167740 [details] merged patch OK, I merged the Makefile changes and followed the suggestions: % portlint looks fine. % make check-plist ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist)
A commit references this bug: Author: rakuco Date: Sat Mar 5 19:07:35 UTC 2016 New revision: 410201 URL: https://svnweb.freebsd.org/changeset/ports/410201 Log: Bring in some fixes from GSoC 2015. There was a GSoC 2015 from Colin Lord to bring to the base system a recent version of Ficl. pfg@ found many bugs in ficl4. Among them: - Fix ficlInstructionPick bug. Pick instructions from 0, not 1. Credit to Toomas Soome from the Illumos project. - Fix some math bugs. Credit to Toomas Soome from the Illumos project. - Fix bug in Ficl stack preventing the stack from growing. Obtained from: http://sourceforge.net/p/ficl/mailman/message/26634755/ - Change rand and srand calls to random and srandom Fix those in the port. While here, unset MAKE_JOBS_UNSAFE as the port builds fine without it, and get rid of the DATA option that has no effect. PR: 207041 Submitted by: pfg Approved by: Pavel Volkov <pavelivolkov@gmail.com> (maintainer) Changes: head/lang/ficl/Makefile head/lang/ficl/files/patch-dictionary.c head/lang/ficl/files/patch-double.c head/lang/ficl/files/patch-ficl.h head/lang/ficl/files/patch-float.c head/lang/ficl/files/patch-primitives.c head/lang/ficl/files/patch-tools.c head/lang/ficl/files/patch-vm.c head/lang/ficl/pkg-descr
Finally landed, thanks guys!