Bug 207062 - [NEW PORT] devel/yaggo: Generate command line parser using getopt_long
Summary: [NEW PORT] devel/yaggo: Generate command line parser using getopt_long
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Raphael Kubo da Costa
URL:
Keywords: feature, needs-patch, patch
Depends on:
Blocks:
 
Reported: 2016-02-09 16:00 UTC by Jason W. Bacon
Modified: 2016-02-26 16:21 UTC (History)
2 users (show)

See Also:
rakuco: maintainer-feedback+

Attachments
Shar archive (2.38 KB, text/plain)
2016-02-09 16:00 UTC, Jason W. Bacon 		no flags Details
Poudriere log (12.26 KB, text/plain)
2016-02-09 16:01 UTC, Jason W. Bacon 		no flags Details
Poudriere log (12.25 KB, text/plain)
2016-02-09 16:01 UTC, Jason W. Bacon 		no flags Details
Poudriere log (12.19 KB, text/plain)
2016-02-09 16:02 UTC, Jason W. Bacon 		no flags Details
Poudriere log (12.24 KB, text/plain)
2016-02-09 16:02 UTC, Jason W. Bacon 		no flags Details
Shar archive (2.39 KB, text/plain)
2016-02-26 16:10 UTC, Jason W. Bacon 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer freebsd_triage 2016-02-09 16:00:48 UTC 
Created attachment 166805 [details]
Shar archive

Generate command line parser using getopt_long.

WWW: https://github.com/gmarcais/yaggo

This is a prerequisite for jellyfish, a component of the Trinity genomics pipeline.
Comment 1 Jason W. Bacon freebsd_committer freebsd_triage 2016-02-09 16:01:33 UTC 
Created attachment 166806 [details]
Poudriere log
Comment 2 Jason W. Bacon freebsd_committer freebsd_triage 2016-02-09 16:01:53 UTC 
Created attachment 166807 [details]
Poudriere log
Comment 3 Jason W. Bacon freebsd_committer freebsd_triage 2016-02-09 16:02:12 UTC 
Created attachment 166808 [details]
Poudriere log
Comment 4 Jason W. Bacon freebsd_committer freebsd_triage 2016-02-09 16:02:31 UTC 
Created attachment 166809 [details]
Poudriere log
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-02-26 14:08:32 UTC 
A couple of suggestions:
* You could set NO_ARCH=yes (it's also suggested in the "install" phase in your Poudriere logs).
* You can make your Makefile patch smaller by doing
  MAKE_ARGS= prefix=${STAGEDIR}${PREFIX}

  If you do this, your patch can be reduced to changing the man pages location:

--- Makefile
+++ Makefile
@@ -6,7 +6,7 @@ all: bin/create_yaggo_one_file
 install: all
        mkdir -p $(prefix)/bin
        mkdir -p $(prefix)/share/doc/yaggo
-       mkdir -p $(prefix)/share/man/man1
+       mkdir -p $(prefix)/man/man1
        cp ./yaggo $(prefix)/bin
        cp ./README.md $(prefix)/share/doc/yaggo
-       ./yaggo -m $(prefix)/share/man/man1/yaggo.1
+       ./yaggo -m $(prefix)/man/man1/yaggo.1
Comment 6 Jason W. Bacon freebsd_committer freebsd_triage 2016-02-26 16:10:26 UTC 
Created attachment 167446 [details]
Shar archive


Thanks for the feedback!

I added NO_ARCH=yes.

I did the patch the way I did because I intend to send it upstream with the hopes that the developer will support staged installs in the next version, eliminating the need for a patch entirely.
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-02-26 16:20:23 UTC 
A commit references this bug:

Author: rakuco
Date: Fri Feb 26 16:20:18 UTC 2016
New revision: 409623
URL: https://svnweb.freebsd.org/changeset/ports/409623

Log:
  New port: devel/yaggo.

  Generate command line parser using getopt_long.

  WWW: https://github.com/gmarcais/yaggo

  PR:		207062
  Submitted by:	Jason Bacon <bacon4000@gmail.com>

Changes:
  head/devel/Makefile
  head/devel/yaggo/
  head/devel/yaggo/Makefile
  head/devel/yaggo/distinfo
  head/devel/yaggo/files/
  head/devel/yaggo/files/patch-Makefile
  head/devel/yaggo/pkg-descr
Comment 8 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-02-26 16:21:02 UTC 
Committed, thank you very much for the contribution!