Bug 207306 - security/py-{acme,letsencrypt}: Update to 0.4.0
Summary: security/py-{acme,letsencrypt}: Update to 0.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks: 207052
  Show dependency tree / graph
 
Reported: 2016-02-18 12:33 UTC by Piotr Kubaj
Modified: 2016-03-01 13:03 UTC (History)
2 users (show)

See Also:

Attachments
poudriere log (61.17 KB, text/plain)
2016-02-18 12:33 UTC, Piotr Kubaj 		no flags Details
v0.4.0 (1.62 KB, patch)
2016-02-18 12:35 UTC, Piotr Kubaj 		koobs: maintainer-approval+
cpm: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2016-02-18 12:33:48 UTC 
Created attachment 167147 [details]
poudriere log

It seems like a simple update.
Log from build is attached.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2016-02-18 12:35:00 UTC 
Created attachment 167148 [details]
v0.4.0
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2016-02-19 04:46:33 UTC 
Assign to maintainer/committer of py-letsencrypt and notify maintainer of py-acme.
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-02-19 10:40:32 UTC 
Testing@work via poudriere on 93i, 10.2i and 10.2a
Comment 4 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-02-19 11:23:19 UTC 
(In reply to Carlos J. Puga Medina from comment #3)

py-letsencrypt and py-acme build fine :)
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-20 14:26:37 UTC 
Comment on attachment 167148 [details]
v0.4.0

Can't set maintainer-* flags without a <maintainer-email> value
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-02-26 12:42:00 UTC 
A commit references this bug:

Author: koobs
Date: Fri Feb 26 12:41:46 UTC 2016
New revision: 409603
URL: https://svnweb.freebsd.org/changeset/ports/409603

Log:
  security/py-{acme,letsencrypt}: Update to 0.4.0

  Common:

  - Update PORTVERSION and distinfo checksum (0.4.0) [1]
  - Update and sort RUN_DEPENDS to match setup.py:install_requires

  security/py-acme:

  - Update COMMENT to match setup.py:description=
  - Add LICENSE_FILE
  - Remove spurious USES=gmake dependency

  PR:		207306 [1]
  Submitted by:	Piotr Kubaj <pkubaj anongoth pl> [1]
  Approved by:	koobs (maintainer, letsencrypt), cpm (maintainer, acme)

Changes:
  head/security/py-acme/Makefile
  head/security/py-acme/distinfo
  head/security/py-letsencrypt/Makefile
  head/security/py-letsencrypt/distinfo
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-26 12:47:18 UTC 
Committed with changes.

Thank you for the submission Piotr :)

Protip: For python port updates, its always worth checking setup.py or requirements files for changes in dependencies, as declarations change often, whether its additions, removals, or version specific updates.

In this case py-openssl was missing from py-acme, and there was an apparently unnecessary dependency on gmake (anyone know why/how?)

@Carlos, for future issues for ports you are maintainer of, don't forget to add maintainer-approval + on the attachment you approve. In letsencrypt/acme's case, we can set multiple (two) flags on a single attachment to declare maintainer approval from both yourself and I.

Since you have special permissions on Bugzilla, it doesn't need to be set to ? <youremail> first, unlike non-committer maintainers.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-26 12:48:09 UTC 
@Carlos, ignore my last comment re maintainer-approval, the template bug in bugzilla made sure I didn't see that you had already set it :)
Comment 9 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-03-01 13:03:33 UTC 
(In reply to Kubilay Kocak from comment #8)

Thanks Kubilay :)