Bug 207737 - sysutils/smartmontools - probably no longer compatible
Summary: sysutils/smartmontools - probably no longer compatible
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-06 12:29 UTC by everytrash
Modified: 2016-03-29 20:54 UTC (History)
2 users (show)

See Also:
amdmi3: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description everytrash 2016-03-06 12:29:15 UTC 
Updating the database with "update-smart-drivedb" shows the following error:

# update-smart-drivedb -v
Download from branches/RELEASE_6_4_DRIVEDB
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   419  100   419    0     0   1365      0 --:--:-- --:--:-- --:--:--  1369
/usr/local/share/smartmontools/drivedb.h.error: rejected by /usr/local/sbin/smartctl, probably no longer compatible

affected version:
smartctl 6.4 2015-06-04 r4109
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-03-29 20:34:38 UTC 
Maintainer timeout. Working on a fix.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-03-29 20:52:28 UTC 
A commit references this bug:

Author: amdmi3
Date: Tue Mar 29 20:52:11 UTC 2016
New revision: 412136
URL: https://svnweb.freebsd.org/changeset/ports/412136

Log:
  - Fix update-smart-drivedb when curl is installed

  update-smart-drivedb is an utility bundled with smartmontools which
  downloads fresh version of smartctl device database from the web.
  It is a shell script which tries to use different http file retrieving
  programs such as wget, curl, lynx, ftp and fetch. If curl is
  installed, it is usually used, however it does't handle HTTP redirect
  which database download url causes (arguments needed to handle it
  not specified?) and downloads redirection page HTML instead of
  actual database. No breakage occurs as the database is verified
  before being installed, so it's just not updated, with error:

  /usr/local/share/smartmontools/drivedb.h.error: rejected by /usr/local/sbin/smartctl, probably no longer compatible

  Patch update-smart-drivedb to only use fetch(1), which is always
  available on FreeBSD. The change provides consistent behavior, and
  fetch(1) handles redirects correctly out of box, so actual database
  is downloaded and successfully installed.

  - While here, fix LICENSE and silence mkdir

  PR:		207737
  Reported by:	everytrash@gmail.com
  Approved by:	maintainer timeout (samm@os2.kiev.ua, 3 weeks)

Changes:
  head/sysutils/smartmontools/Makefile
  head/sysutils/smartmontools/files/patch-update-smart-drivedb.in
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-03-29 20:54:40 UTC 
Fixed. This is not an ideal solution though as the database will be overwritten when smartmontools package is reinstalled. We need a separate port for the database.