Created attachment 167872 [details] Patch to update graphics/tulip to 4.8.1 * Update graphics/tulip to 4.8.1 * Update WRKSRC, distinfo and pkg-plist to be suitable for updated version * Add -lCoin to LDFLAGS to ensure tulip successfully links with the coin library (installed with math/ogdf)
Changes this release: http://tulip.labri.fr/TulipDrupal/?q=node/2121 Depends on PR 207531: Update of math/ogdf to 2015.05
Created attachment 167873 [details] Patch to update graphics/tulip to 4.8.1 Patch updated to fix pkg-plist
Created attachment 167876 [details] QA: Successful poudriere testport logs for graphics/tulip 4.8.1 on FreeBSD 11 amd64 (gzipped)
Hi Kurt: would it be possible to look at committing this update to graphics/tulip today, since the update to math/ogdf recently committed will likely break the old version of tulip in ports.
Testbuilds@work
When I testbuild on 11a, this file was in pkg-plist, but not in the staging area: lib/python/tulipsip.so Testbuilding in poudriere right now with this line removed from pkg-plist.
(In reply to Kurt Jaeger from comment #6) Building under poudriere, also on 11a, lib/python/tulipsip.so was built. Why was it missing with a non-poudriere build ?
Build fail on 9.3a: http://people.freebsd.org/~pi/logs/graphics__tulip-93a-1457547912.txt any ideas ?
(In reply to Kurt Jaeger from comment #8) > Build fail on 9.3a: Hmmm... will look into it now. Sorry for the trouble.
(In reply to Kurt Jaeger from comment #8) > Build fail on 9.3a: > > http://people.freebsd.org/~pi/logs/graphics__tulip-93a-1457547912.txt > > any ideas ? This is caused by libstdc++ 4.8 not making some symbols available (see bug 193528). The following excerpt, present in several ports, makes the port build on 9.3: # Unhide std::to_string() to fix build with GCC (see ports/193528 for details) CXXFLAGS+= -D_GLIBCXX_USE_C99. While here, the port builds fine without setting USE_CXXSTD (tested on 9.3 and HEAD).
(In reply to Raphael Kubo da Costa from comment #10) > This is caused by libstdc++ 4.8 not making some symbols available (see bug > 193528). The following excerpt, present in several ports, makes the port build on > 9.3: > > # Unhide std::to_string() to fix build with GCC (see ports/193528 for details) > CXXFLAGS+= -D_GLIBCXX_USE_C99. Thank you very much for this information Raphael - it will really save me a lot of troubleshooting time, and I appreciate it! > While here, the port builds fine without setting USE_CXXSTD (tested on 9.3 and > HEAD). Ok, I will have a look at both of these things and update my patch. Thanks again.
Testbuilds with suggested changes @work
Testbuilds are fine.
A commit references this bug: Author: pi Date: Mon Mar 14 19:51:12 UTC 2016 New revision: 411112 URL: https://svnweb.freebsd.org/changeset/ports/411112 Log: graphics/tulip: 4.7.0 -> 4.8.1 Changes: http://tulip.labri.fr/TulipDrupal/?q=node/2121 PR: 207818 Submitted by: Ben Woods <woodsb02@gmail.com> (maintainer), rakuco Changes: head/graphics/tulip/Makefile head/graphics/tulip/distinfo head/graphics/tulip/files/patch-CMakeLists.txt head/graphics/tulip/files/patch-plugins_view_HistogramView_HistogramStatistics.cpp head/graphics/tulip/pkg-plist
Committed, thanks!
Thanks for the commit Kurt. My testing shows that the CXXFLAGS+=-D_GLIBCXX_USE_C99 is only required if you are using c++11 with lang/gcc* from ports. Therefore, given that this patch removed the line with USE_CXXSTD=c++11, there is no build of FreeBSD that will use c++11 with lang/gcc* from ports by default. This makes the CXXFLAGS lines a bit unnecessary, but I don't believe it has any negative effect, and will prevent any build errors until PR193528 is fixed if people have non-default environments this arrangement.