Bug 208087 - devel/p5-forks patch
Summary: devel/p5-forks patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-perl (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 13:44 UTC by Vick Khera
Modified: 2016-03-17 14:34 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback+

Attachments
patch to remove version string warning (1.29 KB, patch)
2016-03-17 13:44 UTC, Vick Khera 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vick Khera 2016-03-17 13:44:26 UTC 
Created attachment 168323 [details]
patch to remove version string warning

With modern perl versions (I'm using 5.20), the included Storable module has a version number which is non-numeric. This results in every program written with the p5-forks module to emit this warning:

Argument "2.49_01" isn't numeric in numeric ge (>=) at /usr/local/lib/perl5/site_perl/mach/5.20/forks.pm line 1570.

The module itself has not been updated in a long time, but there is a proposed patch for this on the CPAN bug database at https://rt.cpan.org/Ticket/Display.html?id=102730 which is what I implement with this local patch in the port.

The Debian project has done similar: https://anonscm.debian.org/cgit/pkg-perl/packages/libforks-perl.git/tree/debian/patches/storable-version-check
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2016-03-17 14:03:45 UTC 
What about parsing it with the perl version module instead ?
Comment 2 Vick Khera 2016-03-17 14:26:36 UTC 
This is the least invasive patch, in my opinion.

Personally, I think this module should just require Storable > 2.45 since that version breaks the module, but I'm not in a position to do that.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-03-17 14:27:14 UTC 
because the man page says:

use forks;    #ALWAYS LOAD AS FIRST MODULE, if possible
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-03-17 14:33:05 UTC 
A commit references this bug:

Author: pi
Date: Thu Mar 17 14:32:13 UTC 2016
New revision: 411284
URL: https://svnweb.freebsd.org/changeset/ports/411284

Log:
  devel/p5-forks: remove version string warning

  See
    https://rt.cpan.org/Ticket/Display.html?id=102730
    and
    https://bugs.debian.org/780351

  PR:		208087
  Submitted by:	Vick Khera <vivek@khera.org>

Changes:
  head/devel/p5-forks/Makefile
  head/devel/p5-forks/files/
  head/devel/p5-forks/files/patch-lib_forks.pm
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-03-17 14:34:04 UTC 
Thanks, committed.