Bug 208332 - devel/uclcmd: add port
Summary: devel/uclcmd: add port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-27 16:59 UTC by Johannes Jost Meixner
Modified: 2016-04-14 14:44 UTC (History)
1 user (show)

See Also:

Attachments
uclcmd port (2.96 KB, text/plain)
2016-03-27 16:59 UTC, Johannes Jost Meixner 		no flags Details
uclcmd port mk.II (2.20 KB, text/plain)
2016-03-28 09:46 UTC, Johannes Jost Meixner 		no flags Details
uclcmd port mk.III (2.22 KB, text/plain)
2016-03-28 20:25 UTC, Johannes Jost Meixner 		no flags Details
Updated Makefile (446 bytes, text/plain)
2016-04-01 20:10 UTC, Dmitry Marakasov 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer freebsd_triage 2016-03-27 16:59:19 UTC 
Created attachment 168691 [details]
uclcmd port

* add port to allanjude's uclcmd.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-03-28 02:21:37 UTC 
- Please fix portlint -C warnings
- Upstream Makefile should not hardcode /usr/local
- Port should respect CFLAGS
Comment 2 Johannes Jost Meixner freebsd_committer freebsd_triage 2016-03-28 09:46:50 UTC 
Created attachment 168722 [details]
uclcmd port mk.II

Patch with CRF attached. `portlint` gives 'looks fine' now (embarassing),
and it builds in poudriere.

I suggest we hold off until Allan merges https://github.com/allanjude/uclcmd/pull/14, then replacing the GH_ACCOUNT variable.
Comment 3 Johannes Jost Meixner freebsd_committer freebsd_triage 2016-03-28 20:25:21 UTC 
Created attachment 168736 [details]
uclcmd port mk.III

Now with allanjude as GH_ACCOUNT.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2016-04-01 20:10:47 UTC 
Created attachment 168880 [details]
Updated Makefile

Here's final Makefile, ready to be committed (switched to latest master, removed patches, added pkgconfig dependency).

And one last questions, why's Allan is listed as maintainer and not you?
Comment 5 Johannes Jost Meixner freebsd_committer freebsd_triage 2016-04-04 03:42:47 UTC 
Allan wrote uclcmd. I thought it would make maintaining it easier.
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2016-04-05 16:00:53 UTC 
(In reply to Johannes Jost Meixner from comment #5)
> Allan wrote uclcmd. I thought it would make maintaining it easier.

But you created the port, I assume you're more qualified in maintaining it.
Comment 7 Johannes Jost Meixner freebsd_committer freebsd_triage 2016-04-05 17:53:30 UTC 
(In reply to Dmitry Marakasov from comment #6)
I'm impartial really. If you want, please proceed and replace allan's email with "xmj@chaot.net".

Thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-04-14 14:43:53 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Apr 14 14:43:50 UTC 2016
New revision: 413264
URL: https://svnweb.freebsd.org/changeset/ports/413264

Log:
  Add devel/uclcmd

  uclcmd is a command line tool for working with UCL config files.

  Designed to be somewhat compatible with jq by implementing a very similar
  syntax.

  WWW: https://github.com/allanjude/uclcmd/

  PR:		208332
  Submitted by:	xmj@FreeBSD.org

Changes:
  head/devel/Makefile
  head/devel/uclcmd/
  head/devel/uclcmd/Makefile
  head/devel/uclcmd/distinfo
  head/devel/uclcmd/pkg-descr