Bug 208424 - [PATCH] devel/py-atomicwrites update to 1.0.0
Summary: [PATCH] devel/py-atomicwrites update to 1.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: patch
Depends on:
Blocks: 208428
  Show dependency tree / graph
 
Reported: 2016-03-31 14:40 UTC by Christian Geier
Modified: 2016-04-05 07:24 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback+

Attachments
update devel/py-atomicwrites to 1.0.0 (779 bytes, patch)
2016-03-31 14:40 UTC, Christian Geier 		no flags Details | Diff
poudriere output of building on 10.2 on amd64 (15.24 KB, text/plain)
2016-03-31 20:11 UTC, Christian Geier 		no flags Details
same for 10.1 (15.24 KB, text/plain)
2016-03-31 20:48 UTC, Christian Geier 		no flags Details
and 9.3 (15.33 KB, text/plain)
2016-03-31 20:48 UTC, Christian Geier 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Geier 2016-03-31 14:40:51 UTC 
Created attachment 168827 [details]
update devel/py-atomicwrites to 1.0.0

port builds and runs on
10.1-RELEASE-p31 amd64 
10.2-RELEASE-p14 amd64 
11.0-CURRENT     amd64 
11.0-CURRENT     i386  
9.3-RELEASE-p39  amd64
Comment 1 Maxim Filimonov 2016-03-31 19:43:02 UTC 
Comment on attachment 168827 [details]
update devel/py-atomicwrites to 1.0.0

Note: patch might not apply fully because of #$FreeBSD$ header. Please change the header to the appropriate one from the latest ports tree.

Also, I need to know what portlint and poudriere say about this. Unfortunately, I can't run poudriere myself due to a strange issue. Did you build the port using poudriere?
Comment 2 Christian Geier 2016-03-31 20:11:00 UTC 
portlint says `looks fine`

I'm building with poudriere and will attach some buildlogs.
Comment 3 Christian Geier 2016-03-31 20:11:46 UTC 
Created attachment 168846 [details]
poudriere output of building on 10.2 on amd64
Comment 4 Bryan Drewery freebsd_committer freebsd_triage 2016-03-31 20:17:51 UTC 
(In reply to Maxim Filimonov from comment #1)
> Comment on attachment 168827 [details]
> update devel/py-atomicwrites to 1.0.0
> 
> Note: patch might not apply fully because of #$FreeBSD$ header. Please
> change the header to the appropriate one from the latest ports tree.
> 

It's a trivial change to workaround.  The header is not expanded likely due to using git for a checkout.  It could be committed as is for instance.
Comment 5 Christian Geier 2016-03-31 20:48:34 UTC 
Created attachment 168854 [details]
same for 10.1
Comment 6 Christian Geier 2016-03-31 20:48:56 UTC 
Created attachment 168855 [details]
and 9.3
Comment 7 Maxim Filimonov 2016-04-01 19:01:43 UTC 
Comment on attachment 168827 [details]
update devel/py-atomicwrites to 1.0.0

In fact, you only need to attach a poudriere log for the latest release.

Maintainer-approval: "+". No further questions, everything's fine.
Comment 8 Maxim Filimonov 2016-04-01 19:02:08 UTC 
Thank you very much!
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-04-05 07:22:09 UTC 
A commit references this bug:

Author: pi
Date: Tue Apr  5 07:21:31 UTC 2016
New revision: 412548
URL: https://svnweb.freebsd.org/changeset/ports/412548

Log:
  devel/py-atomicwrites: 0.1.4 -> 1.0.0

  PR:		208424
  Submitted by:	Christian Geier <catcher+freebsdbugzilla@lostpackets.de>
  Approved by:	Maxim Filimonov <che@bein.link> (maintainer)

Changes:
  head/devel/py-atomicwrites/Makefile
  head/devel/py-atomicwrites/distinfo
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2016-04-05 07:24:19 UTC 
Committed, thanks!