Created attachment 169034 [details] Diff for 1.11.5 The existing security/sslscan port is old, and doesn't even support TLS1.1/TLS1.2, making it . Upstream seem to have basically abandoned it, and somebody has forked it and continued development on it. Switch the port to this fork, and update to 1.11.5. Note that this reverts the last major commit to the port (r382059) as that has already been incorporated upstream, in a different way. Gavin
Should there be a maintainer timeout on this, I'm happy to take over maintainership. Gavin
Testbuilds OK on 11a, 10.3a, 10.3i, fails on 9.3a: http://people.freebsd.org/~pi/logs/security__sslscan-93a-1459949750.txt
ACK, thanks; I had tested on 10 and 11, but not 9. I think I have a patch for this, I will test it and update the PR tomorrow.
(In reply to Gavin Atkinson from comment #0) Hi Gavin, why use use GH_TAGNAME = ${PORTVERSION}-${GH_ACCOUNT}? This is update-savvy. Just tried to apply your patch on 9.3-RELEASE to: root@blnn719x - /usr/ports/security/sslscan 2077 # LANG=C svn info Path: . Working Copy Root Path: /usr/ports URL: https://svn0.us-east.freebsd.org/ports/head/security/sslscan Relative URL: ^/head/security/sslscan Repository Root: https://svn0.us-east.freebsd.org/ports Repository UUID: 35697150-7ecd-e111-bb59-0022644237b5 Revision: 412726 Node Kind: directory Schedule: normal Last Changed Author: jkim Last Changed Rev: 382059 Last Changed Date: 2015-03-24 01:28:49 +0100 (Tue, 24 Mar 2015) it does not work: root@blnn719x - /usr/ports/security/sslscan 2080 # LANG=C svn patch 1.11.5.patch U Makefile U distinfo C files/patch-Makefile > rejected hunk @@ -1,22 +1,33 @@ C files/patch-sslscan.c > rejected hunk @@ -1,120 +1,11 @@ Summary of conflicts: Text conflicts: 2
Created attachment 170696 [details] Update to 1.11.6
This new patch updates to 1.11.6 (which has no functional difference to 1.11.5 on FreeBSD but keeps us up-to-date with upstream) and fixes the build issue on FreeBSD 9. I cannot recreate Michael Osipov's patch failure with the newest version of the patch either. Gavin
(In reply to Gavin Atkinson from comment #6) I will retry your patch shortly on 9.3-RELEASE and 10.3-RELEASE and let you know. Note that if you have OpenSSL in place, you should leave the option wether from base or ports. Accordingly CFLAGS and LDFLAGS need to be changed. Some of there I have fixed and reported already: https://github.com/rbsec/sslscan/pull/91 https://github.com/rbsec/sslscan/pull/90
testbuilds of 1.11.6 are fine on all versions, even 9.x 8-}
A commit references this bug: Author: pi Date: Thu May 26 19:55:12 UTC 2016 New revision: 415911 URL: https://svnweb.freebsd.org/changeset/ports/415911 Log: security/sslscan: 1.8.2 -> 1.11.6 - lots of changes since 2010 PR: 208577 Submitted by: gavin Approved by: Matthieu BOUTHORS <matthieu@labs.fr> (maintainer timeout) Changes: head/security/sslscan/Makefile head/security/sslscan/distinfo head/security/sslscan/files/patch-Makefile head/security/sslscan/files/patch-sslscan.c
A commit references this bug: Author: pi Date: Thu May 26 19:56:40 UTC 2016 New revision: 415912 URL: https://svnweb.freebsd.org/changeset/ports/415912 Log: security/sslscan: submitter becomes maintainer PR: 208577 Submitted by: gavin Changes: head/security/sslscan/Makefile
Committed, thanks!
Works like a charm on 10.3-RELEASE and 9.3-RELEASE from ports.