Created attachment 169346 [details] Patch to update multimedia/ffmpegthumbnailer to 2.1.1 - Update multimedia/ffmpegthumbnailer to 2.1.1 - Convert to USE_GITHUB - Convert to USES=cmake - Add patch to prevent cmake trying to find the dl library, since in FreeBSD the dl functions are in the Standard C library (libc) - see dlopen(3) - Pet portlint with other patches (remake the patches with makepatch) This update also allows multimedia/ffmpegthumbnailer to build against ffmpeg 3.0.x. The ports tree currently still has multimedia/ffmepg at version 2.8.6, however this update is backwards compatible with ffmpeg 2.8.6. The update of multimedia/ffmpeg to 3.0.x branch is waiting for ports which depend on it to successfully build with the newer version of ffmpeg.
Changes this release: https://github.com/dirkvdb/ffmpegthumbnailer/blob/2.1.1/ChangeLog
Created attachment 169347 [details] QA: Successful poudriere testport logs for multimedia/ffmpegthumbnailer 1.3.1 against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64
(In reply to Ben Woods from comment #2) I've tested it, it works. You have my appreciations for doing upgrading.
Hi Ben, I'll land a slightly modified version of your patch with some cosmetic changes: * GNU_CONFIGURE=yes is no longer needed now that the port uses CMake. * It's not necessary to set GH_PROJECT when it's the same as PORTNAME. * I'm joining both CMAKE_ARGS assignments for consistency with what we normally do, and it's OK to use 'CMAKE_ARGS=' instead of 'CMAKE_ARGS+=' by default. * I've modified the CMakeLists.txt patch: instead of commenting out some lines, the code now uses the standard CMAKE_LIBS variable. I've also upstreamed this in <https://github.com/dirkvdb/ffmpegthumbnailer/pull/132>.
A commit references this bug: Author: rakuco Date: Sat Apr 16 17:09:08 UTC 2016 New revision: 413461 URL: https://svnweb.freebsd.org/changeset/ports/413461 Log: Update to 2.1.1. - Convert to USE_GITHUB. - Convert to USES=cmake. - Add patch to prevent cmake trying to find the dl library, since in FreeBSD the dl functions are in the Standard C library (libc) - see dlopen(3) - Pet portlint with other patches (remake the patches with makepatch) This update also allows multimedia/ffmpegthumbnailer to build against ffmpeg 3.0.x. The ports tree currently still has multimedia/ffmepg at version 2.8.6, however this update is backwards compatible with ffmpeg 2.8.6. The update of multimedia/ffmpeg to 3.0.x branch is waiting for ports which depend on it to successfully build with the newer version of ffmpeg. PR: 208821 Submitted by: Ben Woods <woodsb02@gmail.com> Approved by: clutton@zoho.com (maintainer) Changes: head/multimedia/ffmpegthumbnailer/Makefile head/multimedia/ffmpegthumbnailer/distinfo head/multimedia/ffmpegthumbnailer/files/patch-CMakeLists.txt head/multimedia/ffmpegthumbnailer/files/patch-dist_ffmpegthumbnailer.thumbnailer head/multimedia/ffmpegthumbnailer/files/patch-libffmpegthumbnailer_jpegwriter.h head/multimedia/ffmpegthumbnailer/pkg-descr head/multimedia/ffmpegthumbnailer/pkg-plist
Committed, thanks everyone.