Bug 209346 - net/opal: Fix build with ffmpeg 3.0.x
Summary: net/opal: Fix build with ffmpeg 3.0.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ben Woods
URL: https://git.archlinux.org/svntogit/pa...
Keywords: patch
Depends on:
Blocks: 207547
  Show dependency tree / graph
 
Reported: 2016-05-06 22:16 UTC by Ben Woods
Modified: 2016-05-10 17:50 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
QA: Successful poudriere testport logs for net/opal with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64 (gzipped) (66.31 KB, application/gzip)
2016-05-06 22:18 UTC, Ben Woods 		no flags Details
Patch to fix build of net/opal using ffmpeg 3.0.x (10.18 KB, patch)
2016-05-06 22:19 UTC, Ben Woods 		no flags Details | Diff
QA: Successful poudriere testport logs for net/opal with patch against FFmpeg 3.0.1 (from PR 207547) on FreeBSD 11-current amd64 (gzipped) (62.36 KB, application/gzip)
2016-05-06 22:57 UTC, Ben Woods 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Woods freebsd_committer freebsd_triage 2016-05-06 22:16:11 UTC 
net/opal: Fix build with ffmpeg 3.0.x

Add patch to allow opal to build successfully once multimedia/ffmpeg is updated to 3.0.x. Note that multimedia/ffmpeg is currently still on the 2.8.x branch, however this patch is backwards compatible with ffmpeg 2.8.x.

Note: this patch was obtained from ArchLinux [1].

  [1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/opal-ffmpeg3.patch?h=packages/opal
Comment 1 Ben Woods freebsd_committer freebsd_triage 2016-05-06 22:18:28 UTC 
Created attachment 170066 [details]
QA: Successful poudriere testport logs for net/opal with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64 (gzipped)
Comment 2 Ben Woods freebsd_committer freebsd_triage 2016-05-06 22:19:58 UTC 
Created attachment 170067 [details]
Patch to fix build of net/opal using ffmpeg 3.0.x
Comment 3 Ben Woods freebsd_committer freebsd_triage 2016-05-06 22:57:58 UTC 
Created attachment 170070 [details]
QA: Successful poudriere testport logs for net/opal with patch against FFmpeg 3.0.1 (from PR 207547) on FreeBSD 11-current amd64 (gzipped)
Comment 4 Ben Woods freebsd_committer freebsd_triage 2016-05-10 08:42:55 UTC 
I will take this bug report, since I now have a commit bit.

Waiting on feedback from gnome@ team.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-05-10 17:50:44 UTC 
A commit references this bug:

Author: woodsb02
Date: Tue May 10 17:50:21 UTC 2016
New revision: 414950
URL: https://svnweb.freebsd.org/changeset/ports/414950

Log:
  net/opal: Fix build with ffmpeg 3.0.x
  - Add patch to allow opal to build successfully once multimedia/ffmpeg
    is updated to 3.0.x. Note that multimedia/ffmpeg is currently still
    on the 2.8.x branch, however this patch is backwards compatible with
    ffmpeg 2.8.x.

  PR:		209346
  Reported by:	antoine (PR207547)
  Reviewed by:	kwm (with gnome hat)
  Approved by:	adamw (mentor)
  Obtained from:	ArchLinux [1]
  Differential Revision:	https://reviews.freebsd.org/D6308

    [1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/opal-ffmpeg3.patch?h=packages/opal

Changes:
  head/net/opal/Makefile
  head/net/opal/files/patch-ffmpeg3