Bug 209446 - sysutils/ipmitool: update to last version and change default sel list output in periodic script
Summary: sysutils/ipmitool: update to last version and change default sel list output ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-11 09:50 UTC by Leonid Nevecherya
Modified: 2017-01-19 14:06 UTC (History)
1 user (show)

See Also:
nevecherya: maintainer-feedback? (zi)
nevecherya: maintainer-feedback-

Attachments
patch.txt (3.88 KB, text/plain)
2016-05-11 09:50 UTC, Leonid Nevecherya 		no flags Details
patch.txt (5.69 KB, patch)
2016-05-11 12:57 UTC, Leonid Nevecherya 		nevecherya: maintainer-approval? (zi)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leonid Nevecherya 2016-05-11 09:50:07 UTC 
Created attachment 170205 [details]
patch.txt

This patch will update sysutils/ipmitool to version 1.8.17 and include patch in bug #209335

Fix: Patch attached.
Comment 1 Leonid Nevecherya 2016-05-11 12:57:12 UTC 
Created attachment 170211 [details]
patch.txt
Comment 2 Leonid Nevecherya 2016-05-11 12:58:07 UTC 
Correct build on FreeBSD 9.x and add missing patch of serial_basic.c file.

Full correct patch attached.
Comment 3 Leonid Nevecherya 2016-05-11 13:23:00 UTC 
Comment on attachment 170211 [details]
patch.txt

Correct build on FreeBSD 9.x and add missing patch of serial_basic.c file.

Full correct patch attached.
Comment 4 Leonid Nevecherya 2016-05-22 18:40:14 UTC 
What is the... ?
Maintainer! Why do not you answer my patch and add you patch?
The adding USE_GCC= yes is epic fail! I am glad to see that Terry Kennedy <TERRY@glaver.org> send correction.

Review you patch!

patch-lib_ipmi__chassis.c is not needed!

#include <ipmitool/bswap.h>
#include <ipmitool/helper.h>
#include <ipmitool/ipmi.h>
#include <ipmitool/log.h>
#include <ipmitool/ipmi_intf.h>
#include <ipmitool/ipmi_strings.h>
#include <ipmitool/ipmi_chassis.h>
#include <ipmitool/bswap.h>

patch-lib_ipmi__pef.c is not needed!

#include <ipmitool/bswap.h>
#include <ipmitool/helper.h>
#include <ipmitool/log.h>
#include <ipmitool/ipmi.h>
#include <ipmitool/ipmi_intf.h>
#include <ipmitool/ipmi_pef.h>
#include <ipmitool/bswap.h>

patch-src_plugins_ipmi__intf.c gives me a strange feeling
+#define __BSD_VISIBLE 1 - This is fine instead my movement define.
+#define s6_addr16 __u6_addr.__u6_addr16 - Not need! You must review source.

patch-src_plugins_open_open.c - This is another way to compile.

Please review my patch of status-ipmi.sh.in!
Comment 5 Ryan Steinmetz freebsd_committer freebsd_triage 2017-01-19 14:05:56 UTC 
Done.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-01-19 14:06:51 UTC 
A commit references this bug:

Author: zi
Date: Thu Jan 19 14:06:38 UTC 2017
New revision: 431876
URL: https://svnweb.freebsd.org/changeset/ports/431876

Log:
  - Update to 1.8.18
  - Update 'sel list' output in periodic script

  PR:		214230, 210068, 209335, 209446
  Submitted by:	Leonid Nevecherya

Changes:
  head/sysutils/ipmitool/Makefile
  head/sysutils/ipmitool/distinfo
  head/sysutils/ipmitool/files/patch-lib_ipmi__cfgp.c
  head/sysutils/ipmitool/files/patch-lib_ipmi__chassis.c
  head/sysutils/ipmitool/files/patch-lib_ipmi__pef.c
  head/sysutils/ipmitool/files/patch-src_plugins_ipmi__intf.c
  head/sysutils/ipmitool/files/patch-src_plugins_open_open.c
  head/sysutils/ipmitool/files/patch-src_plugins_serial_serial__basic.c
  head/sysutils/ipmitool/files/patch-src_plugins_serial_serial__terminal.c
  head/sysutils/ipmitool/files/status-ipmi.sh.in