Bug 209477 - net/pjsip: Update to 2.5
Summary: net/pjsip: Update to 2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 06:26 UTC by Yuri Victorovich
Modified: 2016-05-13 14:27 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+


Attachments
patch (3.71 KB, patch)
2016-05-13 06:26 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2016-05-13 06:26:44 UTC
Created attachment 170240 [details]
patch

Patch updates it to 2.5.

* It disables ALSA module because it depends on SYS_gettid that doesn't exist on FreeBSD and also because ALSA isn't needed. I asked the upstream to add --disable-alsa option in their ML.
* CAVEAT Version 2.5 fails to build in the presence of the previous version due to the libraries mixup during link.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2016-05-13 08:03:25 UTC
(In reply to yuri from comment #0)
> Created attachment 170240 [details]
> patch
> 
> Patch updates it to 2.5.
> 
> * It disables ALSA module because it depends on SYS_gettid that doesn't
> exist on FreeBSD and also because ALSA isn't needed. I asked the upstream to
> add --disable-alsa option in their ML.

Thank you this is very much appreciated!

> * CAVEAT Version 2.5 fails to build in the presence of the previous version
> due to the libraries mixup during link.

Thanks for the notice too, this is somewhat problematic, it will require a notice in UPDATING, to not surprise people upgrading on live system. It's not a problem for poudriere/tinderbox/synth builds.

I'm going to test this update in the next few days.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2016-05-13 08:06:07 UTC
I am sure the link command can be rearranged such that local libs are linked before /usr/local/lib path is added. This is the bug in the upstream that they have such a random link order.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-05-13 14:25:55 UTC
A commit references this bug:

Author: madpilot
Date: Fri May 13 14:25:22 UTC 2016
New revision: 415115
URL: https://svnweb.freebsd.org/changeset/ports/415115

Log:
  - Update net/pjsip to 2.5 [1]
  - Disable unneeded ALSA support in pjsip [1]
  - Replace custom patch with USES=pathfix
  - Fix pjsip build system to allow building while previous version
    is installed in PREFIX/LOCALBASE
  - Bump dependent port asterisk13 PORTREVISION to avoid runtime crash
    (seen while testing)

  PR:		209477 [1]
  Submitted by:	yuri at rawbw.com

Changes:
  head/net/asterisk13/Makefile
  head/net/pjsip/Makefile
  head/net/pjsip/distinfo
  head/net/pjsip/files/patch-Makefile
  head/net/pjsip/files/patch-aconfigure
  head/net/pjsip/files/patch-pjmedia_build_os-auto.mak.in
  head/net/pjsip/pkg-plist
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2016-05-13 14:27:45 UTC
Update committed. Thanks!

BTW I also did fix the build system to allow building with previous version installed. I tested it in a virtual machine.

I also saw asterisk13 crash if pjsip is changed below it without also reinstalling asterisk, hence the asterisk13 port bump.