Bug 209689 - textproc/py-xlrd: Allow concurrent installs
Summary: textproc/py-xlrd: Allow concurrent installs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-05-22 00:55 UTC by John W. O'Brien
Modified: 2016-07-03 08:12 UTC (History)
4 users (show)

See Also:
vlad-fbsd: maintainer-feedback+

Attachments
textproc/py-xlrd: Add USE_PYTHON=concurrent (565 bytes, patch)
2016-05-22 00:55 UTC, John W. O'Brien 		vlad-fbsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2016-05-22 00:55:07 UTC 
Created attachment 170535 [details]
textproc/py-xlrd: Add USE_PYTHON=concurrent

Due to the presence of ${PREFIX}/bin/runxlrd.py, this port needs USE_PYTHON=concurrent to permit concurrent installation with multiple versions of python.
Comment 1 VK 2016-05-23 00:02:56 UTC 
Hi, thanks for the patch. Does 'concurrent' USE_PYTHON change the package? Is portrevision bump required?
Comment 2 John W. O'Brien 2016-05-23 00:07:41 UTC 
Yes, it does change the plist.

Before:

    /usr/local/bin/runxlrd.py

After (e.g. for the default version):

    /usr/local/bin/runxlrd.py
    /usr/local/bin/runxlrd.py-2.7

After (e.g. for a non-default version):

    /usr/local/bin/runxlrd.py-3.4
Comment 3 Dikshie 2016-05-23 14:16:04 UTC 
(In reply to John W. O'Brien from comment #2)

looks good for me.  
please go ahead commit the changes.
Comment 4 dikshie 2016-05-23 14:20:32 UTC 
sorry i logged from wrong account.  

looks good for me.  
please go ahead commit the changes. 
don't forget to bump portrevision. 
thanks you.
Comment 5 VK 2016-05-23 14:35:42 UTC 
Comment on attachment 170535 [details]
textproc/py-xlrd: Add USE_PYTHON=concurrent

Maintainer approved.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-07-03 07:53:45 UTC 
A commit references this bug:

Author: pi
Date: Sun Jul  3 07:53:41 UTC 2016
New revision: 417959
URL: https://svnweb.freebsd.org/changeset/ports/417959

Log:
  textproc/py-xlrd: Allow concurrent installs

  - Add USE_PYTHON=concurrent

  PR:		209689
  Submitted by:	John W. O'Brien <john@saltant.com>
  Approved by:	dikshie@sfc.wide.ad.jp (maintainer)

Changes:
  head/textproc/py-xlrd/Makefile
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-03 08:12:49 UTC 
Committed, thanks!