Bug 209767 - biology/py-biom-format: Fix run-time dependency issues
Summary: biology/py-biom-format: Fix run-time dependency issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Olivier Duchateau
URL:
Keywords: easy, patch, patch-ready
Depends on: 209765 209766
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-26 15:11 UTC by Joseph Mingrone
Modified: 2016-06-11 09:27 UTC (History)
1 user (show)

See Also:

Attachments
svn patch to fix dependency issues (726 bytes, patch)
2016-05-26 15:11 UTC, Joseph Mingrone 		jrm: maintainer-approval+
Details | Diff
Enhance previous patch (1.07 KB, patch)
2016-05-26 20:07 UTC, Olivier Duchateau 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Mingrone freebsd_committer freebsd_triage 2016-05-26 15:11:15 UTC 
Created attachment 170682 [details]
svn patch to fix dependency issues

This fix is dependent on 209766 and 209765 being committed.

portlint: OK
testport: OK (poudriere: 9.3-RELEASE-p39, i386)  [1]
testport: OK (poudriere: 9.3-RELEASE-p39, amd64) [2]
testport: OK (poudriere: 10.3-RELEASE,    i386)  [3]
testport: OK (poudriere: 10.3-RELEASE,    amd64) [4]

[1] http://pkg.awarnach.mathstat.dal.ca/data/9i386-default/2016-05-26_11h10m02s/logs/py27-biom-format-2.1.5_1.log

[2] http://pkg.awarnach.mathstat.dal.ca/data/9amd64-default/2016-05-26_11h44m08s/logs/py27-biom-format-2.1.5_1.log

[3] http://pkg.awarnach.mathstat.dal.ca/data/10i386-default/2016-05-26_11h52m49s/logs/py27-biom-format-2.1.5_1.log

[4] http://pkg.awarnach.mathstat.dal.ca/data/10amd64-default/2016-05-26_12h06m20s/logs/py27-biom-format-2.1.5_1.log
Comment 1 VK 2016-05-26 16:00:45 UTC 
Thanks for the patch. Please approve it (set maintainer-approval+ on it) as you're the maintainer.
Comment 2 Olivier Duchateau freebsd_committer freebsd_triage 2016-05-26 20:07:01 UTC 
devel/py-pyqi is only needed for Python2 (see setup.py line 86). So a test is necessary (I think).

Moreover py27- prefix must be replaced by the ${PYTHON_PKGNAMEPREFIX} macro.
Comment 3 Olivier Duchateau freebsd_committer freebsd_triage 2016-05-26 20:07:58 UTC 
Created attachment 170699 [details]
Enhance previous patch
Comment 4 Joseph Mingrone freebsd_committer freebsd_triage 2016-05-26 20:47:46 UTC 
Comment on attachment 170699 [details]
Enhance previous patch

Thanks for catching these as well.  I've tested in poudriere and installed the resulting package after this patch and it's working well with python27.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-06-11 09:25:42 UTC 
A commit references this bug:

Author: olivierd
Date: Sat Jun 11 09:25:04 UTC 2016
New revision: 416710
URL: https://svnweb.freebsd.org/changeset/ports/416710

Log:
  - Fix run-time dependency issues
  - Bump PORTREVISION

  PR:		209767
  Submitted by:	Joseph Mingrone (maintainer)

Changes:
  head/biology/py-biom-format/Makefile
Comment 6 Olivier Duchateau freebsd_committer freebsd_triage 2016-06-11 09:27:11 UTC 
Committed, thanks!