Bug 209858 - sysutils/syslog-ng: docbook.xsl still used when DOCS option is unset
Summary: sysutils/syslog-ng: docbook.xsl still used when DOCS option is unset
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-05-30 12:54 UTC by staticwizard
Modified: 2016-05-31 13:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
Diff file with a before and after. (749 bytes, patch)
2016-05-30 12:54 UTC, staticwizard 		vlad-fbsd: maintainer-approval? (cy)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description staticwizard 2016-05-30 12:54:07 UTC 
Created attachment 170822 [details]
Diff file with a before and after.

Building package with DOCS option unset still uses docbook.xsl for building the man pages. This caused a build error looking for the docbook.xsl.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2016-05-30 13:12:45 UTC 
This is not a bug in the port but a bug in the upline syslog-ng. Our syslog-ng upline has told me that they did not include man pages in syslog-ng thus the port needs to generate them itself. They will fix this in the next release of syslog-ng.
Comment 2 staticwizard 2016-05-30 13:36:57 UTC 
(In reply to Cy Schubert from comment #1)
Thanks for the quick response Cy Shubert,

Any way I can stop the docs from bulding at all ?
Because I'm using poudriere to build packages with OPTION_UNSET= DOC and
I get an error about the docbook.xsl. I wouldn't expect docs to be build
when unsetting DOCS or I should use another option for skipping documentation
building ?

As mentioned in your response, do you have an ETA for the next release of syslog-ng ?

Thanks
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2016-05-31 13:00:04 UTC 
The syslog-ng upline has produced a specially rolled distfile to address this issue.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-05-31 13:02:28 UTC 
A commit references this bug:

Author: cy
Date: Tue May 31 13:02:21 UTC 2016
New revision: 416196
URL: https://svnweb.freebsd.org/changeset/ports/416196

Log:
  Due to an oversight by the developers of syslog-ng, syslog-ng-3.7.3
  did not contain pre-generated man pages therefore syslog-ng37
  generated them from source. Unfortunately this caused conflicting
  requirements by users of syslog-ng37 between those who wanted man
  pages and those who did not want docbook-xsl as a prerquisite to
  build this port. This commit resolves this by using a specially
  rolled distfile that incluldes pre-generatded man pages. Thank
  you to Peter Czanik of balabit.hu, the company that produces
  syslog-ng, for providing the specially rolled distfile and for
  providing this patch.

  PR:		209858
  Submitted by:	Peter Czanik <peter.czanik@balabit.com>
  		Syslog-ng upline person for FreeBSD support.

Changes:
  head/sysutils/syslog-ng37/Makefile
  head/sysutils/syslog-ng37/distinfo
Comment 5 staticwizard 2016-05-31 13:47:42 UTC 
Wow, this is awesome, super fast response.
Thanks a lot.

Now I don't have to keep a modified Makefile and pkg-list.