Created attachment 170947 [details] patch Made scgi_get_env(), scgi_get_param(), scgi_get_cookie(), and scgi_get_file() consistently reject NULL arguments in all servers. Changed the acceptable parameter quantities to 25 environment variables, 50 parameters, 50 files, and 25 cookies. Added hash table index to speed up scgi_get_env(), scgi_get_param(), scgi_get_cookie(), and scgi_get_file(). Fixed "make debug" target for the threaded library. Added description of use of debugging builds to manuals. Fixed scgi_get_file() in event.c. It was returning char * when it needed to return char **. Clarified used of the -x option in manuals.
Comment on attachment 170947 [details] patch Thanks for the patch. Please approve the patches for ports you maintain by flagging them maintainer-approval+, that way the report becomes visible in the "Maintainer Approved" saved search (at the bottom). ;)
A commit references this bug: Author: riggs Date: Sun Jun 5 10:01:46 UTC 2016 New revision: 416390 URL: https://svnweb.freebsd.org/changeset/ports/416390 Log: Update to upstream version 5.29 Detailed maintainer log: - Made scgi_get_env(), scgi_get_param(), scgi_get_cookie(), and scgi_get_file() consistently reject NULL arguments in all servers. - Changed the acceptable parameter quantities to 25 environment variables, 50 parameters, 50 files, and 25 cookies. - Added hash table index to speed up scgi_get_env(), scgi_get_param(), scgi_get_cookie(), and scgi_get_file(). - Fixed "make debug" target for the threaded library. Added description of use of debugging builds to manuals. - Fixed scgi_get_file() in event.c. It was returning char * when it needed to return char **. - Clarified used of the -x option in manuals. PR: 209969 Submitted by: jimmy@mammothcheese.ca (maintainer) Changes: head/devel/libdombey/Makefile head/devel/libdombey/distinfo